search

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Unnecessary synchronization #135

Closed psygate closed 8 years ago

psygate commented 8 years ago

com.google.guava.Cache implementations are expected to be thread-safe per default. https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/ReinforcementManager.java synchronizes on the cache before access, which is unnecessary. http://docs.guava-libraries.googlecode.com/git/javadoc/com/google/common/cache/Cache.html

ProgrammerDan commented 8 years ago

Appears to have been addressed.