Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Creepers blowing up on reinforced crops causes crops to explode #143

Closed TealNerd closed 8 years ago

TealNerd commented 8 years ago

Not sure if it's an issue with creeper explosions not triggering the explode event, or if the explosion event handling is ignoring crops because it's actually the block under that's reinforced but this is a problemo.

ProgrammerDan commented 8 years ago

I can certainly give this a test on civtest, but what do you mean by "explode" ? They are destroyed instantly (citadel bypass)? They do something else funky?

jjj5311 commented 8 years ago

Is this really a bad thing? Citadel is to protect from other players right

ProgrammerDan commented 8 years ago

In terms of bukkit events, Creepers cause the same event as TNT iirc.

TealNerd commented 8 years ago

@jjj5311 yeah but since creepers should be triggering the same event as tnt I think it's not the creepers, but rather how we handle the event. Either way it's an issue especially with these new mobs spawning everywhere. The spawning creepers could take out your farms before you can get away from them and I don't think that's an intended effect

jjj5311 commented 8 years ago

got it, IIRC the issue will be like you said there is not check if it is a crop, should check if its a crop (utility.isPlant) and then use utility.findplantsoil instead of the getrealblock i think

ProgrammerDan commented 8 years ago

Yeah, sounds about right, thanks man!

TealNerd commented 8 years ago

146 :)