Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

IllegalStateException in EntityListener.explode #159

Closed erocs closed 8 years ago

erocs commented 8 years ago

2016-01-10 15:34:30 [ERROR] Could not pass event EntityExplodeEvent to Citadel v3.4.34 org.bukkit.event.EventException at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:310) ~[spigot.jar:git-Spigot-d97e08b-880a532] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-d97e08b-880a532] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-d97e08b-880a532] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.Explosion.a(Explosion.java:183) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.World.createExplosion(World.java:1883) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.WorldServer.createExplosion(WorldServer.java:1020) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.EntityWitherSkull.a(EntityWitherSkull.java:76) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8R3.EntityFireball.t(EntityFireball.java:130) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.World.entityJoinedWorld(World.java:1623) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.World.g(World.java:1598) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.World.tickEntities(World.java:1437) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.WorldServer.tickEntities(WorldServer.java:597) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.MinecraftServer.B(MinecraftServer.java:785) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.DedicatedServer.B(DedicatedServer.java:374) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.MinecraftServer.A(MinecraftServer.java:653) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:556) [spigot.jar:git-Spigot-d97e08b-880a532] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_72-internal] Caused by: java.lang.IllegalStateException at java.util.ArrayList$Itr.remove(ArrayList.java:864) ~[?:1.8.0_72-internal] at vg.civcraft.mc.citadel.listener.EntityListener.explode(EntityListener.java:68) ~[?:?] at sun.reflect.GeneratedMethodAccessor100.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_72-internal] at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_72-internal] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:306) ~[spigot.jar:git-Spigot-d97e08b-880a532] ... 17 more

goeppes commented 8 years ago

Relevant section Well, it looks like iterator.remove() is getting called twice. Once inside of the check to see if it is a plant, and a second time inside the try-catch.

ProgrammerDan commented 8 years ago

Looks like a case of the missing continue;