Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Integration of cullTimes for reinforcements with NameLayer2.5.43 #166

Closed Scuwr closed 8 years ago

Scuwr commented 8 years ago

For integration with new version of NameLayer2.5.43. Added ability for reinforcements to cull when players in the group are not active.

CullTime is measured in days and the default is 60 days. Tested on localhost test server with one player.

CivcraftBot commented 8 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

Scuwr commented 8 years ago

Made reinforcement damage an exponential function @Maxopoly @ProgrammerDan

Scuwr commented 8 years ago

Also, it's been tested at each edge case and at the base case.

ttk2 commented 8 years ago

So is it doing breaks to the reinforcement based on inactivity?

Scuwr commented 8 years ago

Yes, please check out this issues thread for more information: https://github.com/Civcraft/NameLayer/issues/165

Also be sure to merge and load my NameLayer update before merge Citadel. On Feb 14, 2016 10:08, "ttk2" notifications@github.com wrote:

So is it doing breaks to the reinforcement based on inactivity?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/pull/166#issuecomment-183928860.

ProgrammerDan commented 8 years ago

Ok check my comments and rebase against master so that the merge is clean.

Overall this looks fine otherwise. Reminder to self that https://github.com/Civcraft/NameLayer/pull/166 needs to be merged first to prevent build errors.

Scuwr commented 8 years ago

https://github.com/Civcraft/Citadel/pull/167