search

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Instrumenting proper logging for player actions #174

Closed ProgrammerDan closed 8 years ago

ProgrammerDan commented 8 years ago

Finishing up some basic listeners for player interactions with reinforcements

Cleaned up logging and added more, continuing to work through and clean up codebaes

Cleanup continued with only listeners left and cleanup testing of cleanup.

Adding proper player command response logging, fixes. I think this is largely it for Citadel improvements for now.

Adding command to allow live updating of internal logging.

Fixes based on Zion livetest, works, adjusted logging levels appropriate and have sensible defaults.

ProgrammerDan commented 8 years ago

Obviously a lot of changes. Tested on Zion, working.

Gives much better insight into what's going on within Citadel.

Introduces the /ctsl command to set the new logging on or off.

E.g. /ctsl internal off -- turns internal logging off. /ctsl reinforcement on would turn reinforcement creation logging on (gets spammy, I don't recommend leaving it on).

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

Oh, woops, using java 1.8 methods and all our builds are 1.7

Note to self: https://github.com/Civcraft/Citadel/pull/174/files#diff-9471da9260a340fcf2e3f1f6c1af8bc9R69

rourke750 commented 8 years ago

Update pom to 1.8. We are using that anyways.

ProgrammerDan commented 8 years ago

Works for me.

ProgrammerDan commented 8 years ago

Looks like jenkins doesn't have java 8?

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

I think I'm just going to merge this. We'll do it live. Need solid testing data to know if its working or not anyway. I'll prep the configs per shard.