search

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Reinforced Double Chests Can Be On Two Groups With /ctf #177

Closed Crushtoe closed 8 years ago

Crushtoe commented 8 years ago

Placing down one chest with /ctf on group A will put it on group A. Then switch to /ctf B, and place a chest next to it. The double chest will now be on two different groups, and can be opened by someone on only one of the groups.

It might be possible to use this to access a chest you shouldn't be able to, such as someone's drop chest, by putting down a fortified chest right next to it and opening that side.

ProgrammerDan commented 8 years ago

That's an issue. Wonder what change broke that protection ...

Crushtoe commented 8 years ago

Noticed it 3 days ago while putting down chests in my home in Gimmel.

Maxopoly commented 8 years ago

Just tested this and cant reproduce it, it was actively preventing placing a chest next to it. Did you do anything else?

Crushtoe commented 8 years ago

I had put down the first chest and reinforced it with /ctr, and later made it a double chest. I had used /ctf when I made it a double chest, but it may of just been a fluke.

ProgrammerDan commented 8 years ago

Just looked through the code, and i'll be closing this.

If you have CHEST on both groups this will be allowed. Some foreign group where you don't have access won't be able to place a chest next to yours and steal from you.

Having multiple groups accessible against the same chest is working as designed. The only rule that is tested is if the person placing the new fortified chest has access to the connected chest already or not.