Fix Acid block event - Githubissues

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC

https://github.com/DevotedMC/Citadel

BSD 3-Clause "New" or "Revised" License

6 stars 23 forks source link

Closed ghost closed 7 years ago

ghost commented 7 years ago

The AcidBlockEvent class had a misnamed method and also didn't provide an accessor to get the player associated with the event.

CivcraftBot commented 7 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

ghost commented 7 years ago

do I keep the typo then?

ok I re-added the typo method and marked it as depreciated. The API should remain compatible now.

ProgrammerDan commented 7 years ago

Perfect.

ProgrammerDan commented 7 years ago

Ok last thing, just increment the version in the pom

ghost commented 7 years ago

added

ProgrammerDan commented 7 years ago

Looks like you need to rebase this against latest.

ghost commented 7 years ago

interesting. idk how my fork got so out of date. It should be fixed now though.

ProgrammerDan commented 7 years ago

Eh, it happens :D

ghost commented 7 years ago

thanks