search

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

Piston heads get stuck if they touch a reinforced block #67

Closed not-nocturnal closed 8 years ago

not-nocturnal commented 9 years ago

While reinforced pistons not retracting seems to be fixed, I've discovered a new issue:

If a piston head extends to touch a reinforced block, the head gets stuck extended until the reinforced block is broken. This happens regardless of whether the piston is reinforced. This does not happen if the reinforced block is above, below or to the sides of the extended piston head.

2015-02-09_09 35 09 Civtest as of 15-02-09 9:35 UTC+0 top dirt block: unreinforced, bottom dirt block: reinforced

rourke750 commented 9 years ago

Its been like this a while

not-nocturnal commented 9 years ago

Oh, fair enough. I guess I'd somehow not encountered it until now. Didn't notice it in any of the existing/closed issues so I made a new one.

spaceFountain commented 9 years ago

Yep. Honestly though it could be fixed so probably worth doing. Biggest problem might be a race condition if the group is modified somehow while the piston is moving.

rourke750 commented 9 years ago

Should be modified since it's all synchronous. Anyways we can just add a check if it is a piston (not a sticky) and it won't pull anything so well allow it. On Feb 9, 2015 8:44 PM, "spaceFountain" notifications@github.com wrote:

Yep. Honestly though it could be fixed so probably worth doing. Biggest problem might be a race condition if the group is modified somehow while the piston is moving.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/issues/67#issuecomment-73629262.

suirad commented 8 years ago

@ProgrammerDan I may look into this as well.

suirad commented 8 years ago

@PatchyKnowly are you still able to reproduce this? I am trying to in my testing enviroment and am unable to.

not-nocturnal commented 8 years ago

Oh gosh, this was quite a long time ago, before 1.8 even.

Anyway, I did a test on CivTemp just now and I can't reproduce it, so it seems it got fixed at some point. I suppose this can be closed.