search

Civcraft / Citadel

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Citadel
BSD 3-Clause "New" or "Revised" License
6 stars 23 forks source link

getReinforcement NPE during blockBreakEvent #84

Closed erocs closed 9 years ago

erocs commented 9 years ago

[ERROR] Could not pass event BlockBreakEvent to Citadel v3.2.5 org.bukkit.event.EventException at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:302) ~[spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:62) ~[spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at org.bukkit.plugin.SimplePluginManager.fireEvent(SimplePluginManager.java:502) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:487) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.PlayerInteractManager.breakBlock(PlayerInteractManager.java:264) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.PlayerInteractManager.a(PlayerInteractManager.java:192) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.PlayerConnection.a(PlayerConnection.java:565) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.PacketPlayInBlockDig.a(SourceFile:53) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.PacketPlayInBlockDig.handle(SourceFile:8) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.NetworkManager.a(NetworkManager.java:184) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.ServerConnection.c(ServerConnection.java:81) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.MinecraftServer.v(MinecraftServer.java:734) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.DedicatedServer.v(DedicatedServer.java:289) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.MinecraftServer.u(MinecraftServer.java:584) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.MinecraftServer.run(MinecraftServer.java:490) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] at net.minecraft.server.v1_7_R4.ThreadServerApplication.run(SourceFile:628) [spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] Caused by: java.lang.NullPointerException at vg.civcraft.mc.citadel.ReinforcementManager.getReinforcement(ReinforcementManager.java:114) ~[?:?] at vg.civcraft.mc.citadel.listener.BlockListener.blockBreakEvent(BlockListener.java:136) ~[?:?] at sun.reflect.GeneratedMethodAccessor84.invoke(Unknown Source) ~[?:?] at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.7.0_75] at java.lang.reflect.Method.invoke(Method.java:606) ~[?:1.7.0_75] at org.bukkit.plugin.java.JavaPluginLoader$1.execute(JavaPluginLoader.java:298) ~[spigot.jar:git-Spigot-1.7.9-R0.2-203-g02dec9b] ... 15 more

rourke750 commented 9 years ago

Huh some how here: https://github.com/Civcraft/Citadel/blob/master/src/vg/civcraft/mc/citadel/listener/BlockListener.java#L135 it isnt finding the correct block event though it is confirmed to be there when isPlant() is called. Are we running citadel build 103?

WildWeazel commented 9 years ago

Seems like this would happen whenever a plant is not where we would expect it to have grown. Naturally spawned cactus, for example, could be taller than expected. isPlant() doesn't guarantee anything about the blocks below it.

ttk2 commented 9 years ago

yes 103 is live.

On Tue, Mar 24, 2015 at 10:44 PM Travis Christian notifications@github.com wrote:

Seems like this would happen whenever a plant is not where we would expect it to have grown. Naturally spawned cactus, for example, could be taller than expected. isPlant() doesn't guarantee anything about the blocks below it.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/issues/84#issuecomment-85816839.

jjj5311 commented 9 years ago

I think we just need to check if reinforcingBlock is null before passing to getReinforcement?

or should getReinforcement automatically return null if it is passed a null value?

rourke750 commented 9 years ago

Yea that's all I'm going to do On Mar 25, 2015 3:42 PM, "jjj5311" notifications@github.com wrote:

I think we just need to check if reinforcingBlock is null before passing to getReinforcement?

or should getReinforcement automatically return null if it is passed a null value?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/issues/84#issuecomment-86188141.

rourke750 commented 9 years ago

https://github.com/Civcraft/Citadel/commit/8436d86eed16f99ddcf3b41c5a54582b4b7af7c0

rourke750 commented 9 years ago

@ttk2 new jar

rourke750 commented 9 years ago

Tell me when its up

ttk2 commented 9 years ago

its up.

On Thu, Mar 26, 2015 at 6:14 PM rourke750 notifications@github.com wrote:

Tell me when its up

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Citadel/issues/84#issuecomment-86750556.