Civcraft / CivMenu

BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Fixing bugs with the TOS and adding help menus #1

Closed idoash4 closed 9 years ago

idoash4 commented 9 years ago

The TOS should work now. The plugin will also automatically generate help menus for each plugin. Instead of the bukkit format with pages it will create a menu http://imgur.com/a/eTWEn . I still need to format it so it will look better. It should work with any plugin with a normal yml file using the command /help PluginName. It shows the name of the plugin and it is description under it(if it has one, namelayer doesn't have one in its yml file) and all the commands. Hovering over a commands will explain what it does. Clicking on it was supposed to place the command in the player's chat but this option doesnt seem to work... Let me know if you like this.

TO DO list:

@rourke750 @ttk2

erocs commented 9 years ago

We can finally get rid of the book, sweet!

rourke750 commented 9 years ago

@erocs Lol I hate how we did books in humbug. It's so annoying when trying to use humbug on other servers.

idoash4 commented 9 years ago

I use it for my own testing. I forgot to remove it, I will in a second.

rourke750 commented 9 years ago

ok to test

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

rourke750 commented 9 years ago

ok to test

rourke750 commented 9 years ago

ok to test

ttk2 commented 9 years ago

Ok just got a chance to try this out on Civtest, its nice, a little too spammy though, ideally the message will be like, "welcome to Civcraft, please read and agree to the terms of service at this link, type /tos agree" where the link is in blue, even if the whole message is the link its a browser thing people will be familiar with.

Having them type it is probably best, although I am willing to go with just having it printed on login, maybe have a a toggle "must agree" which will toggle between a "by joining you agree" message and one that requires input.

Next up is the method of preventing people from doing things, holding them in one spot feels too disruptive, maybe let them walk around a little then teleport them back to where they started and send the message again? That way its not so spammy.

Next up is setting this up to integrate with the larger purpose of Civmenu well, it needs either a single centralized database like namelayer or some sort of sharding support so that people don't agree to the TOS on every server, after thats handled we can start building it out as the general tutorial plugin we want.

Great work black, thanks a ton, pretty soon you may have the plugin players most use on civcraft

idoash4 commented 9 years ago

Ok just got a chance to try this out on Civtest, its nice, a little too spammy though, ideally the message will be like, "welcome to Civcraft, please read and agree to the terms of service at this link, type /tos agree" where the link is in blue, even if the whole message is the link its a browser thing people will be familiar with.

I think simply changing the text and the style to make it look more like a button will do the work.

Having them type it is probably best, although I am willing to go with just having it printed on login, maybe have a a toggle "must agree" which will toggle between a "by joining you agree" message and one that requires input.

This is possible. My original plan was to place the command for them in chat when they click the message so they have to click the message and click enter to sign. Sadly this feature does not seem to work no matter what I try doing.

Next up is the method of preventing people from doing things, holding them in one spot feels too disruptive, maybe let them walk around a little then teleport them back to where they started and send the message again? That way its not so spammy.

I can definitely do this. I can store the location of players that login and didn't sign the TOS and teleport them back when they are X blocks away from the location. Another nice thing I can add is kicking player that didnt agree to the TOS after X ticks.

ttk2 commented 9 years ago

I think simply changing the text and the style to make it look more like a button will do the work.

just something that shows them that it's a link is important.

This is possible. My original plan was to place the command for them in chat when they click the message so they have to click the message and click enter to sign. Sadly this feature does not seem to work no matter what I try doing.

sounds like a lot of things in Minecraft, so long as the command is simple and short it should not be an issue, legally its probably better that they type something.

I can definitely do this. I can store the location of players that login and didn't sign the TOS and teleport them back when they are X blocks away from the location. Another nice thing I can add is kicking player that didnt agree to the TOS after X ticks.

That sounds great.

rourke750 commented 9 years ago

@BlackXnt This good for merging or are you doing more?

idoash4 commented 9 years ago

I still need to make the menus look a bit better before we can go online with this so hold on with merging.

ttk2 commented 9 years ago

@BlackXnt bump

rourke750 commented 9 years ago

Going to merge this and work on some stuff.

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.