search

Civcraft / CivMenu

BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Redesigning the menus #3

Closed idoash4 closed 8 years ago

idoash4 commented 8 years ago

http://imgur.com/a/jOOGl

It is a bit better now. I am open for more suggestions.

ghost commented 8 years ago

Damn that's nice.

Don't know how useful that Namelayer help menu is. I can never remember what the commands stand for. Maybe show the regular versions instead of the aliases.

On Tue, Sep 15, 2015 at 12:12 PM, BlackXnt notifications@github.com wrote:

http://imgur.com/a/jOOGl

It is a bit better now. I am open for more suggestions.

You can view, comment on, or merge this pull request online at:

https://github.com/Civcraft/CivMenu/pull/3 Commit Summary

  • Merge pull request #4 from Civcraft/master
  • redesigning the menus

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/CivMenu/pull/3.

rourke750 commented 8 years ago

It gives help when hovering over. When I get the chance I'll look it over. On Sep 15, 2015 12:15 PM, "Dr. Andrew Jawa" notifications@github.com wrote:

Damn that's nice.

Don't know how useful that Namelayer help menu is. I can never remember what the commands stand for. Maybe show the regular versions instead of the aliases.

On Tue, Sep 15, 2015 at 12:12 PM, BlackXnt notifications@github.com wrote:

http://imgur.com/a/jOOGl

It is a bit better now. I am open for more suggestions.

You can view, comment on, or merge this pull request online at:

https://github.com/Civcraft/CivMenu/pull/3 Commit Summary

  • Merge pull request #4 from Civcraft/master
  • redesigning the menus

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/CivMenu/pull/3.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/CivMenu/pull/3#issuecomment-140447910.

idoash4 commented 8 years ago

As rourke said hovering over a command will explain what it does and how to use it. http://imgur.com/BXkiRU0

ttk2 commented 8 years ago

so will the automatic advice text things be handled similarly?

idoash4 commented 8 years ago

The automatic advices are not coded yet. They require changes in the code of most of our plugins. The changes here only require minor changes in the yml files of some of our plugins.

ttk2 commented 8 years ago

how is a player supposed to know hovering does anything?

rourke750 commented 8 years ago

@BlackXnt Is this tested?

idoash4 commented 8 years ago

@rourke750 yes

@ttk2 I think it is pretty obvious. The commands in the menus look like buttons.

rourke750 commented 8 years ago

Anyways I think these are really nice changes. Anything you want to add or good for merge?

idoash4 commented 8 years ago

good for merge

idoash4 commented 8 years ago

Please merge all the other pulls I made and put them on civtest.

ttk2 commented 8 years ago

that's going to be a pain. is thee just one for everything? I didn't keep track.