Closed idoash4 closed 8 years ago
Damn that's nice.
Don't know how useful that Namelayer help menu is. I can never remember what the commands stand for. Maybe show the regular versions instead of the aliases.
On Tue, Sep 15, 2015 at 12:12 PM, BlackXnt notifications@github.com wrote:
It is a bit better now. I am open for more suggestions.
You can view, comment on, or merge this pull request online at:
https://github.com/Civcraft/CivMenu/pull/3 Commit Summary
- Merge pull request #4 from Civcraft/master
- redesigning the menus
File Changes
- M plugin.yml https://github.com/Civcraft/CivMenu/pull/3/files#diff-0 (2)
- M src/vg/civcraft/mc/civmenu/CivMenu.java https://github.com/Civcraft/CivMenu/pull/3/files#diff-1 (60)
- M src/vg/civcraft/mc/civmenu/CivMenuAPI.java https://github.com/Civcraft/CivMenu/pull/3/files#diff-2 (2)
- M src/vg/civcraft/mc/civmenu/CommandHandler.java https://github.com/Civcraft/CivMenu/pull/3/files#diff-3 (12)
- M src/vg/civcraft/mc/civmenu/Menu.java https://github.com/Civcraft/CivMenu/pull/3/files#diff-4 (35)
- M src/vg/civcraft/mc/civmenu/TOSListener.java https://github.com/Civcraft/CivMenu/pull/3/files#diff-5 (33)
Patch Links:
— Reply to this email directly or view it on GitHub https://github.com/Civcraft/CivMenu/pull/3.
It gives help when hovering over. When I get the chance I'll look it over. On Sep 15, 2015 12:15 PM, "Dr. Andrew Jawa" notifications@github.com wrote:
Damn that's nice.
Don't know how useful that Namelayer help menu is. I can never remember what the commands stand for. Maybe show the regular versions instead of the aliases.
On Tue, Sep 15, 2015 at 12:12 PM, BlackXnt notifications@github.com wrote:
It is a bit better now. I am open for more suggestions.
You can view, comment on, or merge this pull request online at:
https://github.com/Civcraft/CivMenu/pull/3 Commit Summary
- Merge pull request #4 from Civcraft/master
- redesigning the menus
File Changes
- M plugin.yml https://github.com/Civcraft/CivMenu/pull/3/files#diff-0 (2)
- M src/vg/civcraft/mc/civmenu/CivMenu.java https://github.com/Civcraft/CivMenu/pull/3/files#diff-1 (60)
- M src/vg/civcraft/mc/civmenu/CivMenuAPI.java https://github.com/Civcraft/CivMenu/pull/3/files#diff-2 (2)
- M src/vg/civcraft/mc/civmenu/CommandHandler.java https://github.com/Civcraft/CivMenu/pull/3/files#diff-3 (12)
- M src/vg/civcraft/mc/civmenu/Menu.java https://github.com/Civcraft/CivMenu/pull/3/files#diff-4 (35)
- M src/vg/civcraft/mc/civmenu/TOSListener.java https://github.com/Civcraft/CivMenu/pull/3/files#diff-5 (33)
Patch Links:
— Reply to this email directly or view it on GitHub https://github.com/Civcraft/CivMenu/pull/3.
— Reply to this email directly or view it on GitHub https://github.com/Civcraft/CivMenu/pull/3#issuecomment-140447910.
As rourke said hovering over a command will explain what it does and how to use it. http://imgur.com/BXkiRU0
so will the automatic advice text things be handled similarly?
The automatic advices are not coded yet. They require changes in the code of most of our plugins. The changes here only require minor changes in the yml files of some of our plugins.
how is a player supposed to know hovering does anything?
@BlackXnt Is this tested?
@rourke750 yes
@ttk2 I think it is pretty obvious. The commands in the menus look like buttons.
Anyways I think these are really nice changes. Anything you want to add or good for merge?
good for merge
Please merge all the other pulls I made and put them on civtest.
that's going to be a pain. is thee just one for everything? I didn't keep track.
http://imgur.com/a/jOOGl
It is a bit better now. I am open for more suggestions.