Fixes - Githubissues

Civcraft / CivMenu

BSD 3-Clause "New" or "Revised" License

0 stars 4 forks source link

Closed suirad closed 9 years ago

suirad commented 9 years ago

This fixes Civcraft/CivMenu#5, Civcraft/CivMenu#6, Civcraft/CivMenu#8

I have tested all changes.

Spelling error corrected
PlayerMoveEvent will not process a null location
Respawning clears the old location, and the move event updates itself with the new location after respawn. This works after death, and also if the player is kicked while dead and respawns after a reconnect.

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

Maxopoly commented 9 years ago

ok to test

Maxopoly commented 9 years ago

Can I even do that?

suirad commented 9 years ago

I already have #4 finished, should i just commit and pin it onto this pull or just wait until after this pull is merged so its separate?

Maxopoly commented 9 years ago

make a new branch, pull from civcraft's master into that branch, then do your changes and make a new pull request from that branch.

suirad commented 9 years ago

Sounds good.

suirad commented 9 years ago

This should be good to merge.

ttk2 commented 9 years ago

ok doing so.