Civcraft / Humbug

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Humbug
BSD 3-Clause "New" or "Revised" License
3 stars 11 forks source link

Strengh reverting during fights #13

Closed jjj5311 closed 9 years ago

jjj5311 commented 9 years ago

Look all over the subreddit to see this issue being talked about

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1487-L1512

I think this has to be where the issue is as it is the only thing dealing with damage dealt, could also be in the armor section as well

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1061-L1105

I don't see anything blatantly obvious here

ttk2 commented 9 years ago

If its as occasional as it is described then I think it might be spigot not us

On Fri, Mar 6, 2015 at 8:14 AM jjj5311 notifications@github.com wrote:

Look all over the subreddit to see this issue being talked about

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1487-L1512

I think this has to be where the issue is as it is the only thing dealing with damage dealt, could also be in the armor section as well

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1061-L1105

I don't see anything blatantly obvious here

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/issues/13.

TealNerd commented 9 years ago

I figured this out and we can't do anything about it. When the tick is really bad the EntityDamageByEntityEvent fucks up and doesn't get fired

ttk2 commented 9 years ago

I figured it was a bukkit think. How did you determine it?

On Tue, Mar 10, 2015, 10:57 PM biggestnerd notifications@github.com wrote:

I figured this out and we can't do anything about it. When the tick is really bad the EntityDamageByEntityEvent fucks up and doesn't get fired

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/issues/13#issuecomment-78201307.

TealNerd commented 9 years ago

I was testing another plugin that uses the event and when the tick dropped on my testing server the event wasn't always firing

jjj5311 commented 9 years ago

i think this one can be closed then?

ttk2 commented 9 years ago

Its still an issue. We just can't do anything about it.

On Mon, Apr 6, 2015, 8:20 AM jjj5311 notifications@github.com wrote:

i think this one can be closed then?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/issues/13#issuecomment-90035553.

suirad commented 9 years ago

Should be labeled as such

ttk2 commented 9 years ago

wontfix?

suirad commented 9 years ago

Yea that sounds good. If its something that is affected by lag and/or bukkit, it doesn't leave much room to play with it. A wontfix/bukkit-issue label and a close would suffice.

suirad commented 9 years ago

Please close and label wontfix