Civcraft / Humbug

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Humbug
BSD 3-Clause "New" or "Revised" License
3 stars 11 forks source link

Prot nerfed against arrows to enable for 2 class PVP #18

Closed Xavter closed 9 years ago

Xavter commented 9 years ago

A rough draft based on what I said in https://github.com/Civcraft/Humbug/issues/16 to make prot vulnerable to arrows while keeping proj prot very effective at stopping arrows, thus making a two kit PVP system.

Some problems with first commit: the damage modifier is based on diamond armor vs iron or leather armor, where it may be doing too much extra damage. Additionally, the current prot enchantment will also be more vulnerable to thrown potions - this is easy to fix I believe but I coded this on my phone and simply couldn't get to it.

rourke750 commented 9 years ago

@ttk2 What do you want to do with this?

ttk2 commented 9 years ago

not sure.

On Tue, Mar 17, 2015 at 12:42 PM rourke750 notifications@github.com wrote:

@ttk2 https://github.com/ttk2 What do you want to do with this?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/18#issuecomment-82494505.

ghost commented 9 years ago

I think Xavter is looking into merging this into bergypvp rather than humbug.

On Tue, Mar 17, 2015 at 8:43 PM, ttk2 notifications@github.com wrote:

not sure.

On Tue, Mar 17, 2015 at 12:42 PM rourke750 notifications@github.com wrote:

@ttk2 https://github.com/ttk2 What do you want to do with this?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/18#issuecomment-82494505.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/18#issuecomment-82655672.

Xavter commented 9 years ago

Yeah, I've been drained for time, but I plan on bringing the code over to the bergecraft repository soon. You should maybe switch the issue to the BC repository, too.

rourke750 commented 9 years ago

bump

Xavter commented 9 years ago

I shoulda spent this sunday coding more instead of playing on the server, haha. My weeks are getting more open, I will get to this as soon as possible, and there are some bits of code that are ambiguous as to whether they fit within a plugin for scarcity or PVP, so I may ask a few questions.

ttk2 commented 9 years ago

Ask away

On Mon, Mar 30, 2015, 7:07 AM Xavter notifications@github.com wrote:

I shoulda spent this sunday coding more instead of on the server, haha. My weeks are getting more open, I will get to this as soon as possible, and there are some bits of code that are ambiguous as to whether they fit within a plugin for scarcity or PVP, so I may ask a few questions.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/18#issuecomment-87651871.

Xavter commented 9 years ago

Should the deathlog, deathred, and other pieces of 'death' code go into Bergey? I think we want mob loot multipliers and XP disabling code in Humbug, but I could see it in Bergey too: Where do these go? And where do vehicle and hunger tweaking code go?

Xavter commented 9 years ago

Also should we clear out existing BergeyPVP code and substitute what we already have in humbug or should we keep everything in there? The existing BergeyPVP code makes the merging part of this whole thing a lot less trivial than would be simply copying and pasting, so knowing exactly what we'd want to do with this would be a big help.

ttk2 commented 9 years ago

combat stuff only is Bergy.

On Mon, Mar 30, 2015 at 8:39 AM Xavter notifications@github.com wrote:

Also should we clear out existing BergeyPVP code?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/18#issuecomment-87685479.

Maxopoly commented 9 years ago

Closing this, because Xavter is most likely not gonna do dev stuff anymore or fix this pull and we wont bother with PvP balance on 1.8 anyway

ttk2 commented 9 years ago

what happened to him anyways?

Maxopoly commented 9 years ago

I'm not sure either. His git account here is not his main account, he just made it for civ and rarely checks it. Also he kind of wanted to quit completly but then didnt, I really dont know.