search

Civcraft / Humbug

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Humbug
BSD 3-Clause "New" or "Revised" License
3 stars 11 forks source link

kick players off vehicles even without PlayerQuit event #2

Closed benjajaja closed 10 years ago

benjajaja commented 10 years ago

when server is ctrl-c'd, it does not seem to fire PlayerQuit events

ttk2 commented 10 years ago

this is a very specific area, why does it need correction?

On Sun, Oct 5, 2014 at 11:17 AM, Benjamin Grosse notifications@github.com wrote:

when server is ctrl-c'd, it does not seem to fire PlayerQuit events

You can merge this Pull Request by running

git pull https://github.com/gipsy-king/Humbug leave_vehicles

Or view, comment on, or merge it at:

https://github.com/Civcraft/Humbug/pull/2 Commit Summary

  • kick players off vehicles even without PlayerQuit event

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/2.

rourke750 commented 10 years ago

If a player is in a minecart when the server shuts down, players will still be in the minecart. Could cause falling through bedrock. This is a nice sanity check.
Looks good I'm going to merge it unless you have an objection?

ttk2 commented 10 years ago

looks ok.

On Sun, Oct 5, 2014 at 6:08 PM, rourke750 notifications@github.com wrote:

If a player is in a minecart when the server shuts down, players will still be in the minecart. Could cause falling through bedrock. This is a nice sanity check.

Looks good I'm going to merge it unless you have an objection?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/2#issuecomment-57956054.

rourke750 commented 10 years ago

So just get a new build off of jenkins.

ttk2 commented 10 years ago

This is for burricos compatibility so its not needed right away. Going onto Civtest tomorrow morning though. On Oct 5, 2014 6:34 PM, "rourke750" notifications@github.com wrote:

So just get a new build off of jenkins.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/2#issuecomment-57956734.

benjajaja commented 10 years ago

Actually it's not needed for Burricos, I just found out about this while working on it.

Also, it's only needed for when the server stops from a ctrl-c, a regular /stop should fire PlayerQuit events for each player, AFAIK.