search

Civcraft / Humbug

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Humbug
BSD 3-Clause "New" or "Revised" License
3 stars 11 forks source link

Add option for obsidian generators #25

Closed TealNerd closed 9 years ago

TealNerd commented 9 years ago

Works as they currently do, doesn't affect generation on version that have it anyway, just where they dont

ttk2 commented 9 years ago

did you test this in 1.8?

On Fri, Apr 17, 2015 at 11:14 AM biggestnerd notifications@github.com wrote:

Works as they currently do, doesn't affect generation on version that have

it anyway, just where they dont

You can view, comment on, or merge this pull request online at:

https://github.com/Civcraft/Humbug/pull/25 Commit Summary

  • Update Humbug.java

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/25.

TealNerd commented 9 years ago

Yep! Also humbug in its current state compiles fine against 1.8 so that's good

On Friday, April 17, 2015, ttk2 notifications@github.com wrote:

did you test this in 1.8?

On Fri, Apr 17, 2015 at 11:14 AM biggestnerd <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Works as they currently do, doesn't affect generation on version that have

it anyway, just where they dont

You can view, comment on, or merge this pull request online at:

https://github.com/Civcraft/Humbug/pull/25 Commit Summary

  • Update Humbug.java

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/25.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/25#issuecomment-94059119.

ttk2 commented 9 years ago

I will merge it then. It is disabled by default right?

On Fri, Apr 17, 2015, 2:36 PM biggestnerd notifications@github.com wrote:

Yep! Also humbug in its current state compiles fine against 1.8 so that's good

On Friday, April 17, 2015, ttk2 notifications@github.com wrote:

did you test this in 1.8?

On Fri, Apr 17, 2015 at 11:14 AM biggestnerd <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Works as they currently do, doesn't affect generation on version that have

it anyway, just where they dont

You can view, comment on, or merge this pull request online at:

https://github.com/Civcraft/Humbug/pull/25 Commit Summary

  • Update Humbug.java

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/25.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/25#issuecomment-94059119.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/25#issuecomment-94059279.

rourke750 commented 9 years ago

@ttk2 Pls don't merge until I review pls.

TealNerd commented 9 years ago

I think I set it true by default because I wanted it that way but that can be changed really easy if you want me to

ttk2 commented 9 years ago

of by default, so that needs a new pull.

On Sat, Apr 18, 2015 at 10:43 PM biggestnerd notifications@github.com wrote:

I think I set it true by default because I wanted it that way but that can be changed really easy if you want me to

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/25#issuecomment-94231874.

TealNerd commented 9 years ago

Yeah I'll fix it when I get home in a few minutes. I'll just commit to my fork and it should auto update this pull

TealNerd commented 9 years ago

@Rourke750 pls pls pls pls pls

rourke750 commented 9 years ago

@TealNerd Did you test it?

CivcraftBot commented 9 years ago

Can one of the admins verify this patch?

rourke750 commented 9 years ago

test this please

TealNerd commented 9 years ago

Yeah I actually did test this multiple times on different versions of 1.7.10 and 1.8.3

WildWeazel commented 9 years ago

ok to test

rourke750 commented 9 years ago

@WildWeazel Looks like it isnt commenting success or not

WildWeazel commented 9 years ago

at least it said something

rourke750 commented 9 years ago

ok to test

TealNerd commented 9 years ago

wtf just happened to travis

rourke750 commented 9 years ago

ok to test

WildWeazel commented 9 years ago

@TealNerd I'm fine!

TealNerd commented 9 years ago

@WildWeazel lol

CivcraftBot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://192.99.169.83:8080//job/Humbug-pull/4/ Test Passed.

WildWeazel commented 9 years ago

\o/

rourke750 commented 9 years ago

@WildWeazel Fuck yea got it.

TealNerd commented 9 years ago

woah there's a @CivcraftBot ? i thought @ttk2 was against botting?

WildWeazel commented 9 years ago

@rourke750 nice, what was the problem?

rourke750 commented 9 years ago

@WildWeazel Had to specify the url of Jenkins in one of the options and the key code thing was never inputted.

WildWeazel commented 9 years ago

Of course it would be a missing field. If you don't want to make all of the -pull projects yourself I can script it once @ttk2 gives me console access again. Actually I may just make a plugin that automatically sets up master/dev/pull projects for every repo.

ttk2 commented 9 years ago

working on the access.

On Sat, Apr 18, 2015 at 11:22 PM Travis Christian notifications@github.com wrote:

Of course it would be a missing field. If you don't want to make all of the -pull projects yourself I can script it once @ttk2 https://github.com/ttk2 gives me console access again.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/25#issuecomment-94233656.