search

Civcraft / Humbug

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Humbug
BSD 3-Clause "New" or "Revised" License
3 stars 11 forks source link

1.8 Banners #29

Closed idoash4 closed 9 years ago

idoash4 commented 9 years ago

Allow players to equip a banner by left clicking while holding it.

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

rourke750 commented 9 years ago

ok to test

rourke750 commented 9 years ago

Have you tested this?

CivcraftBot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://192.99.169.83:8080//job/Humbug-pull/5/ Test PASSed.

idoash4 commented 9 years ago

Before making the pull request I made a new plugin with the method of the event in it and it worked. I installed the new build of humbug with the pull request on my server but when I try to run the command "humbug equipping_banners true" it says "unknown option". It should be false by default.

idoash4 commented 9 years ago

Can you build it again?

CivcraftBot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://192.99.169.83:8080//job/Humbug-pull/6/ Test PASSed.

CivcraftBot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://192.99.169.83:8080//job/Humbug-pull/7/ Test PASSed.

idoash4 commented 9 years ago

So after my debug messages didnt show up I decided to decompile the jar the bot built for me. The changes I made weren't there. So it looks like the bot isnt doing his job properly or I am a complete idiot.

rourke750 commented 9 years ago

ok to test

CivcraftBot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://192.99.169.83:8080//job/Humbug-pull/8/ Test PASSed.

rourke750 commented 9 years ago

ok to test

rourke750 commented 9 years ago

I think what happened was it was building against the mast branch.

CivcraftBot commented 9 years ago

Refer to this link for build results (access rights to CI server needed): http://192.99.169.83:8080//job/Humbug-pull/10/ Test PASSed.

rourke750 commented 9 years ago

Huh looks like it does infact build and make sure it works but does not input the code. You should be fine with this.

idoash4 commented 9 years ago

What do you mean by "not input the code"? The last 2 builds(8 and 10) still don't have any of the changes I made.

rourke750 commented 9 years ago

Because I don't think it is meant to actually compile the pull request. It is meant to check and make sure the pull request won't fail when merged into the main branch. Like if you were to make it so this pull request wouldn't compile properly this would not pick it up.

idoash4 commented 9 years ago

I see. Do you want to build it manually so I can test if the feature is actually working before you merge it?

rourke750 commented 9 years ago

It looks correct. I'm doing a feature hold until we actually go onto 1.8.3. After that I'll flag this ready for civtest hop on quickly make sure it works and it should be good to go.

idoash4 commented 9 years ago

Ok great

ttk2 commented 9 years ago

this can't be automerged, could you rebase and resubmit

rourke750 commented 9 years ago

I can fix it On May 17, 2015 9:51 PM, "ttk2" notifications@github.com wrote:

this can't be automerged, could you rebase and resubmit

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/29#issuecomment-102888688.

idoash4 commented 9 years ago

https://github.com/Civcraft/Humbug/pull/42