search

Civcraft / Humbug

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Humbug
BSD 3-Clause "New" or "Revised" License
3 stars 11 forks source link

remove disable_xp_orbs #44

Closed jjj5311 closed 9 years ago

jjj5311 commented 9 years ago

May add into its own method but I dont think performance wise it will even help

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

jjj5311 commented 9 years ago

22

ttk2 commented 9 years ago

we are removing this because its not duplicate with Factorymod right?

On Mon, May 18, 2015 at 11:25 AM jjj5311 notifications@github.com wrote:

22 https://github.com/Civcraft/Humbug/issues/22

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/44#issuecomment-103118759.

jjj5311 commented 9 years ago

Removing cause it's essentially useless

On Monday, May 18, 2015, ttk2 notifications@github.com wrote:

we are removing this because its not duplicate with Factorymod right?

On Mon, May 18, 2015 at 11:25 AM jjj5311 <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

22 https://github.com/Civcraft/Humbug/issues/22

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/44#issuecomment-103118759.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/44#issuecomment-103237712.

rourke750 commented 9 years ago

@jjj5311 useless how? Is this code somewhere else?

jjj5311 commented 9 years ago

Not yet, it only disabled xp orbs dropped from killing mobs... I will add a method in the future that will actually disable all xp orbs from mobs, mining, and whatever else you can get orbs from in vanilla

On Tue, May 19, 2015 at 4:16 PM, rourke750 notifications@github.com wrote:

@jjj5311 https://github.com/jjj5311 useless how? Is this code somewhere else?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/44#issuecomment-103669172.

rourke750 commented 9 years ago

Well, id rather not remove this and let people get xp without a fix :/

jjj5311 commented 9 years ago

xp is still disabled... this only removes the orbs

On Tue, May 19, 2015 at 4:19 PM, rourke750 notifications@github.com wrote:

Well, id rather not remove this and let people get xp without a fix :/

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/44#issuecomment-103669925.

jjj5311 commented 9 years ago

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1712

jjj5311 commented 9 years ago

@rourke750 this should be merged

rourke750 commented 9 years ago

Did you test to see if they would not spawn?

jjj5311 commented 9 years ago

They xp orbs will spawn without this, however players are not awarded xp from orbs since https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1712

rourke750 commented 9 years ago

I don't think you are linking to the right line.

jjj5311 commented 9 years ago

yeah forgot to check the link i just copied it

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1768

rourke750 commented 9 years ago

That's only triggered when a player throws an xp bottle. On Jul 2, 2015 11:16 AM, "jjj5311" notifications@github.com wrote:

yeah forgot to check the link i just copied it

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1768

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/Humbug/pull/44#issuecomment-118064839.

jjj5311 commented 9 years ago

Look down to the next method

jjj5311 commented 9 years ago

https://github.com/Civcraft/Humbug/blob/master/src/main/java/com/untamedears/humbug/Humbug.java#L1782