search

Civcraft / Humbug

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/Humbug
BSD 3-Clause "New" or "Revised" License
3 stars 11 forks source link

Add smooth double slabs #56

Closed Maxopoly closed 9 years ago

Maxopoly commented 9 years ago

Adressing https://github.com/Civcraft/FactoryMod/issues/121

Mojang decided it was a good idea to make it literally impossible to have the smooth double slab blocks in your inventory in 1.8, so this instead creates a lored single slab by crafting and adds a listener, which sets the block to a double slab after placing, if it has the lore.

Review would be appreciated

CivcraftBot commented 9 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

ttk2 commented 9 years ago

sounds like somthing that could easily go wrong for some gain, well actually how stable is a hack like this?

Maxopoly commented 9 years ago

Basically the crafting recipe turns 4 slabs into 2 slabs with lore and the listener turns those half slabs into full blocks again. I would try to cover as many scenarios as possible while testing it, but I dont really see how this could generate a dupe that could slip through.

ttk2 commented 9 years ago

well obviously its the ones you don't see that get you, price of complexity, from player demand its probably worth it though

ttk2 commented 9 years ago

@erocs @rourke750

What do yall think of the way this is setup? Player demand is pretty high, worth it?

ProgrammerDan commented 9 years ago

I always expected to put this into FactoryMod, since it already has custom recipes built in, but should be worthwhile if it works well.

rourke750 commented 9 years ago

@ProgrammerDan Was just about to say. Move this to factorymod. I try to not pay attention to the balancing stuff. Other people can deal with that but yea this needs to move to factorymod.

@Maxopoly https://github.com/Civcraft/FactoryMod/blob/master/config.yml#L405 add is there, close this after too pls.

rourke750 commented 9 years ago

ok to test