search

Civcraft / JukeAlert

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/JukeAlert
BSD 3-Clause "New" or "Revised" License
5 stars 15 forks source link

Mute persist #17

Closed jjj5311 closed 9 years ago

jjj5311 commented 9 years ago

This is pretty ugly but it is working

Tested it and no more exceptions were coming up, this probably needs to be tested on a larger database then my 2 accounts lol

I can do the code cleanup once it has been tested and is working

ttk2 commented 9 years ago

we would prefer the tested and working thing happen before it gets merged into main, Wild was working on some way for us to get the build server to make a .jar without putting it in main

On Wed Feb 11 2015 at 8:13:19 PM Jacob Jungbluth notifications@github.com wrote:

This is pretty ugly but it is working

Tested it and no more exceptions were coming up, this probably needs to be tested on a larger database then my 2 accounts lol

I can do the code cleanup once it has been tested and is working

You can view, comment on, or merge this pull request online at:

https://github.com/Civcraft/JukeAlert/pull/17 Commit Summary

  • Start on mute persist
  • Fix of Persist Juke

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/pull/17.

jjj5311 commented 9 years ago

Well I tested everything and it seems to work as desired.

Really there isnt much to clean up but the old ignore group stuff I just commented out

On Wednesday, February 11, 2015, ttk2 notifications@github.com wrote:

we would prefer the tested and working thing happen before it gets merged into main, Wild was working on some way for us to get the build server to make a .jar without putting it in main

On Wed Feb 11 2015 at 8:13:19 PM Jacob Jungbluth <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

This is pretty ugly but it is working

Tested it and no more exceptions were coming up, this probably needs to be tested on a larger database then my 2 accounts lol

I can do the code cleanup once it has been tested and is working

You can view, comment on, or merge this pull request online at:

https://github.com/Civcraft/JukeAlert/pull/17 Commit Summary

  • Start on mute persist
  • Fix of Persist Juke

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/pull/17.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/pull/17#issuecomment-74016260.

rourke750 commented 9 years ago

@jjj5311 So you think this is ready?

jjj5311 commented 9 years ago

Yeah I think it works, I tested locally, but only 2 accounts... I think it's good for civtest

On Sunday, February 15, 2015, rourke750 notifications@github.com wrote:

@jjj5311 https://github.com/jjj5311 So you think this is ready?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/pull/17#issuecomment-74426721.

rourke750 commented 9 years ago

@ttk2 Civtest pls.

ttk2 commented 9 years ago

done

On Mon Feb 16 2015 at 8:38:39 PM rourke750 notifications@github.com wrote:

@ttk2 https://github.com/ttk2 Civtest pls.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/pull/17#issuecomment-74608777.