search

Civcraft / JukeAlert

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/JukeAlert
BSD 3-Clause "New" or "Revised" License
5 stars 15 forks source link

Truncation of long player names leads to unnecessary confusion #25

Closed ProgrammerDan closed 9 years ago

ProgrammerDan commented 9 years ago

https://github.com/Civcraft/JukeAlert/blob/master/src/com/untamedears/JukeAlert/chat/SendSnitchInfo.java#L55

This line has caused me no end of problems, heh. The rationale for artificially limiting the displayed length of some of the most important information from the Juke logs has never sat well with me. I'm happy to address this one myself but figured I'd toss up an issue in case there was an actual legitimate reason.

ProgrammerDan commented 9 years ago

I lied; this is the offending line: https://github.com/Civcraft/JukeAlert/blob/master/src/com/untamedears/JukeAlert/storage/JukeAlertLogger.java#L1192

erocs commented 9 years ago

It seems to make space for 20 chars. How is that truncating 16 char names? On May 12, 2015 1:20 PM, "Daniel Boston" notifications@github.com wrote:

I lied; this is the offending line: https://github.com/Civcraft/JukeAlert/blob/master/src/com/untamedears/JukeAlert/storage/JukeAlertLogger.java#L1192

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/issues/25#issuecomment-101409020.

ProgrammerDan commented 9 years ago

?? Player names are not limited to 16 characters. I routinely see people on snitches who names exceed the displayed value, and as a consequence their name is truncated. I am unable to appropriately pursue them in a bounty as I can't identify that it is indeed them.

ProgrammerDan commented 9 years ago

Or, are you suggesting that the database itself is hardcoded to only store 16 characters for each actor's name? That's ... well, that's terrible, if it's the case. I had assumed the 16 char DB field was for UNID, not translated actor name.

rourke750 commented 9 years ago

A players name cannot exceed 16 characters is what he is saying. On May 12, 2015 6:13 PM, "Daniel Boston" notifications@github.com wrote:

Or, are you suggesting that the database itself is hardcoded to only store 16 characters for each actor's name? That's ... well, that's terrible, if it's the case. I had assumed the 16 char DB field was for UNID, not translated actor name.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/issues/25#issuecomment-101438400.

ProgrammerDan commented 9 years ago

And I am saying that that is incorrect. I'll dig up some evidence in a bit.

On Tue, May 12, 2015 at 6:39 PM, rourke750 notifications@github.com wrote:

A players name cannot exceed 16 characters is what he is saying. On May 12, 2015 6:13 PM, "Daniel Boston" notifications@github.com wrote:

Or, are you suggesting that the database itself is hardcoded to only store 16 characters for each actor's name? That's ... well, that's terrible, if it's the case. I had assumed the 16 char DB field was for UNID, not translated actor name.

— Reply to this email directly or view it on GitHub <https://github.com/Civcraft/JukeAlert/issues/25#issuecomment-101438400 .

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/issues/25#issuecomment-101445812.

ProgrammerDan commented 9 years ago

Alright, the name length may not be incorrect, but here's an example of the clipping in the client:

http://imgur.com/Oysx6hA

The full name is EnderPearlHarbor, but the /jainfo command only displays EnderPearlHar.

This occurs regularly.

erocs commented 9 years ago

That's the group name.

Edit: Teach me to not look at the pic. Let me actually look, but MC names can only be 16 characters.

erocs commented 9 years ago

No, no that's player name. It's something about whatever magic ChatFiller is failing to do properly. Just remove ChatFiller.fillString from that line you pointed out and I would think things would work.

On Tue, May 12, 2015 at 5:09 PM, Nick erocss@gmail.com wrote:

That's the group name.

On Tue, May 12, 2015 at 4:40 PM, Daniel Boston notifications@github.com wrote:

Alright, the name length may not be incorrect, but here's an example of the clipping in the client:

http://imgur.com/Oysx6hA

The full name is EnderPearlHarbor, but the /jainfo command only displays EnderPearlHar.

This occurs regularly.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/issues/25#issuecomment-101460756.

rourke750 commented 9 years ago

@erocs I think the fill line is so that each thing is for sure on one line.

erocs commented 9 years ago

But its truncating the name when it shouldn't.

On Tue, May 12, 2015 at 5:56 PM, rourke750 notifications@github.com wrote:

@erocs https://github.com/erocs I think the fill line is so that each thing is for sure on one line.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/issues/25#issuecomment-101472155.