Closed suirad closed 9 years ago
@rourke750 @ttk2 @drjawa Good to merge
You got the wrong import for chatcolor
@rourke750 https://github.com/rourke750 @ttk2 https://github.com/ttk2 @drjawa https://github.com/drjawa Good to merge, this probably needs a CLA
— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/pull/32#issuecomment-114597873.
@rourke750 good catch, want me to submit another pull or not worry about it?
you should't need a new pull just fix it in your master and it will be added here as another commit... nevermind its already merged
@drjawa ...................
@suirad looks like you need to do a new pull
Ah okay, wasnt sure it would pick it up since its already merged. Actually if jawa/rourke wants to revert i can squash that new commit no problem
Oh you said it was good to merge. Missed the chat color. I reverted.
Though it seems once a pull is closed it doesn't reopen so a new pull might be needed away.
Well the revert wasn't needed. It'll just complicate things. On Jun 23, 2015 2:58 PM, "Dr. Andrew Jawa" notifications@github.com wrote:
Oh you said it was good to merge. Missed the chat color. I reverted.
— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/pull/32#issuecomment-114608264.
Updated my commit, want me to make another pull?
Yes pls On Jun 23, 2015 3:01 PM, "Darius Scott" notifications@github.com wrote:
Updated my commit, want me to make another pull?
— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/pull/32#issuecomment-114609807.
Added a bit of code to update mercury functionality of JukeAlert. Added a configurable option to enable/disable cross server snitch alerts.