search

Civcraft / JukeAlert

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/JukeAlert
BSD 3-Clause "New" or "Revised" License
5 stars 15 forks source link

Breaking snitches reveals who owns it? #49

Closed TealNerd closed 8 years ago

TealNerd commented 8 years ago

I remember precious stones had this. I think it would be nice to bring back, maybe only for not blocks to encourage the use of jukes if you want full anonymity?

@rourke750 @ttk2 thoughts?

ttk2 commented 8 years ago

so the noteblock would report who owned it but a snitch would not? why not just have both report who owns them?

On Sun, Nov 22, 2015 at 10:50 AM, biggestnerd notifications@github.com wrote:

I remember precious stones had this. I think it would be nice to bring back, maybe only for not blocks to encourage the use of jukes if you want full anonymity?

@rourke750 https://github.com/rourke750 @ttk2 https://github.com/ttk2 thoughts?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/issues/49.

Maxopoly commented 8 years ago

You could argue that the juke is a lot more expensive, but I think if we add this we should add it for both.

TealNerd commented 8 years ago

It could do that, I was just thinking since jukes are significantly more expensive it would be nice to give them that bonus. Plus jukes are typically used to snitch people's own stuff, whereas noteblocks are typically used to spam snitches in other people's stuff. It would either make it much easier for someone to check who's been snitching their stuff, or would force people to pay more for their networks.

That said if you think it should just be for all snitches that sounds good as well

ttk2 commented 8 years ago

Jukes are more expensive, but that cost is for info storage, do we really want to attach it to some other benefit? I think we should just do it for all of them.

On Sun, Nov 22, 2015 at 11:58 AM, biggestnerd notifications@github.com wrote:

It could do that, I was just thinking since jukes are significantly more expensive it would be nice to give them that bonus. Plus jukes are typically used to snitch people's own stuff, whereas noteblocks are typically used to spam snitches in other people's stuff. It would either make it much easier for someone to check who's been snitching their stuff, or would force people to pay more for their networks.

That said if you think it should just be for all snitches that sounds good as well

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/issues/49#issuecomment-158781517.

TealNerd commented 8 years ago

Yeah that's true. Ok I'll implement it with just a config options to turn it on or off

rourke750 commented 8 years ago

So for this issue, you would need to store who reinforced a snitch not the group. How would you go about implementing this for prexisting snitches?

What approach do we want to take. Owner of group would be easiest and would not require any db changes. What were you thinking @TealNerd?

Maxopoly commented 8 years ago

The commit he added to the other PR a few days ago used the owner of the group: https://github.com/TealNerd/JukeAlert/commit/4fb8199b1181eabe5511028e5f9afe91db0bf7ed

I think additionally to the owner it should also show the name of the group, that would tell a lot.

rourke750 commented 8 years ago

https://github.com/Civcraft/JukeAlert/pull/50