Civcraft / JukeAlert

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/JukeAlert
BSD 3-Clause "New" or "Revised" License
5 stars 15 forks source link

DB bootstrapping fails #6

Closed erocs closed 9 years ago

erocs commented 9 years ago

https://www.reddit.com/r/Civcraft/comments/2m2ipo/civcraft_development_juke_alert_modification/cm0rpue

No problem. A few things I found when doing some basic tests last night.

https://github.com/Civcraft/JukeAlert/blob/master/src/com/untamedears/JukeAlert/storage/JukeAlertLogger.java#L172[1] reference tables 'snitchs' but doesn't take into account the table prefix.

https://github.com/Civcraft/JukeAlert/blob/master/src/com/untamedears/JukeAlert/storage/JukeAlertLogger.java#L199[2] procedure makes use of LogHours before column was added in https://github.com/Civcraft/JukeAlert/blob/master/src/com/untamedears/JukeAlert/storage/JukeAlertLogger.java#L206[3]

There were a handfull of other items but basically makes it so noone can use jukealerts without hand hacking the database.

Pentom commented 9 years ago

Issue can be closed at this point with the pull inclusion.

erocs commented 9 years ago

Thanks! ca3a929e771