Civcraft / JukeAlert

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/JukeAlert
BSD 3-Clause "New" or "Revised" License
5 stars 15 forks source link

Some maintenance / code debt #74

Closed ProgrammerDan closed 7 years ago

ProgrammerDan commented 7 years ago

https://github.com/Civcraft/JukeAlert/blob/master/src/com/untamedears/JukeAlert/chat/SendSnitchInfo.java#L36-L42

This is super clever -- but bad form. Parsing a string with regex that the application itself just finished generating, to get a value that only a microsecond before was available as an int, is bad form. Ideally this should be rewritten so that the required values are simply kept available after DB retrieval, instead of requiring string parsing.