search

Civcraft / JukeAlert

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/JukeAlert
BSD 3-Clause "New" or "Revised" License
5 stars 15 forks source link

Add timezone information to /jainfo #75

Closed waffle-stomper closed 7 years ago

waffle-stomper commented 7 years ago

Closes #18

This adds an extra line to the /jainfo header. For example:

Snitch Log for Wheat_Farm -----------------------------------
All times are EDT (UTC-04:00)
 $59 = Wheat
 Name                Reason                Details

I'm not very familiar with git yet, so I'm not sure why there are four commits showing up here instead of just the one. I thought the merge would take care of that?

CivcraftBot commented 7 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

Maxopoly commented 7 years ago

Could you make the timezone configurable for others running the plugin?

waffle-stomper commented 7 years ago

I'm using the system timezone to generate that line, which I believe is what's used for generating the times in the report. It shouldn't need any manual configuring, should it?

Maxopoly commented 7 years ago

Oh yeah, nevermind, I read UTC in the diff and thought it was completly hardcoded. @ProgrammerDan any objections?

ProgrammerDan commented 7 years ago

Assuming tested, no objections. Perhaps toss on test first so we can test along with minecart location breaks.

@waffle-stomper Doublecheck the snitch log parsing in Snitch Visualizer, once this is merged and online one of us would probably have to add a change to the parse-logic :).

waffle-stomper commented 7 years ago

@ProgrammerDan Haha! If I'd realized I was making more work for myself, I would have chosen a different issue to fix!

I've tested it locally and it seems to work as intended.