Civcraft / JukeAlert

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/JukeAlert
BSD 3-Clause "New" or "Revised" License
5 stars 15 forks source link

Add snitch names to jalist output #77

Closed waffle-stomper closed 8 years ago

waffle-stomper commented 8 years ago

Fixes #24

I've tested it locally against Spigot 1.10.2 and it seems to work as intended. The columns are a little wonky, but I don't think that's fixable unless Minecraft reverts to a monospaced font.

CivcraftBot commented 8 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

Maxopoly commented 8 years ago

You should consider using rebase instead of local merge, so you don't have 5 merge commits in each PR. Assuming this is tested, it looks nice though.

waffle-stomper commented 8 years ago

Thanks for the tip! I'm still figuring out how to use git.

I've tested it locally and it seems fine.

erocs commented 8 years ago

World names would matter for non-sharded servers.

waffle-stomper commented 8 years ago

That's a good point.

I could probably add a config option that enables the world name column, (by reducing the width of the group and snitch name columns), and disables the world name in the header, (since it only displays the world name for the first snitch in the list). Would that work?

waffle-stomper commented 8 years ago

I've added the config option I mentioned. I've tested locally it and it seems to work as intended.

The only thing I'm not sure about is the name of the config entry, ('multipleWorldSupport'), since it's referring to multiple worlds on a single server. For Civcraft, multipleWorldSupport would be set to false, (which is the default).

Maxopoly commented 8 years ago

Ok, nice. Good work