search

Civcraft / JukeAlert

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/JukeAlert
BSD 3-Clause "New" or "Revised" License
5 stars 15 forks source link

Remove string parsing #79

Closed waffle-stomper closed 7 years ago

waffle-stomper commented 8 years ago

Fixes #74

Hopefully I haven't broken anything! I've tested it locally and it seems to work as intended, but there's a good chance I've missed something.

Side note - does anyone know if GetSnitchInfoTask is still being used for something? The only reference to it that I can find is in JukeAlertLogger.getSnitchInfo(Location loc, int offset), which isn't called by anything in JukeAlert. I think it might have been orphaned at some point, but I've updated it just in case it's still in use.

CivcraftBot commented 8 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

Maxopoly commented 8 years ago

Didnt find anything obvious bad about it. You said you tested it, so seems fine to merge. I'll wait with merging because Dan said he wanted to look at it later today.

Maxopoly commented 7 years ago

Or maybe not. Oh well

ProgrammerDan commented 7 years ago

Been busy