search

Civcraft / JukeAlert

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/JukeAlert
BSD 3-Clause "New" or "Revised" License
5 stars 15 forks source link

JukeAlert - Issue#6 - Fix for DB Bootstrapping Failure #8

Closed Pentom closed 9 years ago

Pentom commented 9 years ago

Resolved a few issues that were preventing the database upgrade / database installation for users. Fixed issue with snitches table reference not accepting the proper prefixed snitch table. Fixed issue with procedure attempting to be created prior to column existing. Added said column to the list of things not to throw an error for since that is now the first item that would be found in said 'try catch' block.

Pentom commented 9 years ago

NOTE - I didn't want to pollute a pull request that is an obvious bug fix with a pull request for adding logging. Whats the best way to handle this in 'github'? If you have a reference to the M in RTFM I will accept that also.

erocs commented 9 years ago

Either have a separate branch for a separate pull request or, preferably, just add the second commit to your pull request. Git really tracks by the commits and not so much by pull requests so describing those reasonably is better anyway.

ttk2 commented 9 years ago

I assume I should put the new build up on civ test? I didn't see any database conversion issues with the first one On Nov 15, 2014 12:19 AM, "erocs" notifications@github.com wrote:

Merged #8 https://github.com/Civcraft/JukeAlert/pull/8.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/pull/8#event-193716225.

erocs commented 9 years ago

You can but it won't do anything. The DB changes have already been done there.

Pentom commented 9 years ago

TTK - this was bug fixes for code that was unrelated to the recent lever change. Basically, anyone trying to use juke alert recently has had it fail because the database wouldnt fully deploy. This will affect new users but won't affect you as your installation is already up to date (has triggers/etc).

ttk2 commented 9 years ago

cool, its up on Civtest regardless though

On Sat, Nov 15, 2014 at 1:10 AM, Pentom notifications@github.com wrote:

TTK - this was bug fixes for code that was unrelated to the recent lever change. Basically, anyone trying to use juke alert recently has had it fail because the database wouldnt fully deploy. This will affect new users but won't affect you as your installation is already up to date (has triggers/etc).

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/JukeAlert/pull/8#issuecomment-63163466.