Replace tabs with spaces

Civcraft / JukeAlert

Do not open issues here; open them on the maintained fork @ DevotedMC

https://github.com/DevotedMC/JukeAlert

BSD 3-Clause "New" or "Revised" License

5 stars 15 forks source link

Closed waffle-stomper closed 7 years ago

waffle-stomper commented 7 years ago

Closes #81

I was going to submit this to the Devoted fork, but its last commit was four months ago.

CivcraftBot commented 7 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

Maxopoly commented 7 years ago

@ProgrammerDan should this be merged?

@waffle-stomper this has conflicts after merging your other PR

ProgrammerDan commented 7 years ago

Wait, just re-read the title. If this converts tabs to spaces then absolutely not.

We use tabs here for indentation. So if it converts everything to spaces, kill it.

ProgrammerDan commented 7 years ago

Yeah no.

@waffle-stomper please leverage https://github.com/Civcraft/style-guide which is based on a lengthy collaborative agreement between the lead devs.

tl;dr 120 char line lengths, tabs not spaces, and a host of other little things.

waffle-stomper commented 7 years ago

@ProgrammerDan - I misread a comment of yours about tabs vs. spaces in another PR and thought spaces were the standard. Thanks for clearing it up.