search

Civcraft / NameLayer

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/NameLayer
BSD 3-Clause "New" or "Revised" License
4 stars 14 forks source link

[Major Issue] Restarting the server unlinks all sublinks #189

Closed kujukuju closed 8 years ago

kujukuju commented 8 years ago

Just as the title says. When the server restarts, all links between groups are dropped.

ProgrammerDan commented 8 years ago

This is truly mystifying. In my testing on other servers this does not occur.

kujukuju commented 8 years ago

On other servers as in other shards? Or other servers as in testing servers?

This issue has been happening in Aleph. Have you been able to verify that I'm not just crazy?

EDIT: Maybe it's relevant that we have multiple subgroups. I don't remember this happening when we just had 1, but I could be wrong.

ProgrammerDan commented 8 years ago

When I checked the db a few days ago it seemed to confirm. I do need to do some controlled testing, however. To my knowledge there is nothing that should be unlinking well-formed groups on start or stop, but I'll keep looking.

awoo-civ commented 8 years ago

Same for me in Bet, all linked groups get unlinked on every restart.

ttk2 commented 8 years ago

are links not stored with the main group data? maybe its just not being loaded.

ProgrammerDan commented 8 years ago

They are a separate table. I think something is explicitly calling unlink when data is unloaded for save... possibly.

not-nocturnal commented 8 years ago

Just want mention that this seems to be intermittent. I've currently got two supergroups I manage, one with three subgroups and one with one. Sometimes all of them unlink, but occasionally one or two of them will stay linked across a restart. Something sharding-related, maybe?

ttk2 commented 8 years ago

that's possible, I have you tried doing this with a group that's never touched in another shard and then a group that is?

That sounds like the fastest way to test that idea.

not-nocturnal commented 8 years ago

I'm currently at the group limit, however, from what I've observed:
super: a (created in aleph) / sub: chansn (created in bet) / sometimes unlinks super: a (created in aleph) / sub: nixsn (created in bet) / sometimes unlinks super: a (created in aleph) / sub: nixdef (created in bet) / sometimes unlinks super: nic (created in bet) / sub: nic-1 (created in zion) / has never unlinked so far

edit: nic-1 finally unlinked from nic today (2016-03-30), so I guess it wasn't immune to the bug. I wasn't online for a lot of the day so I'm not sure exactly which restart it happened on, though.

ProgrammerDan commented 8 years ago

@PatchyKnowly It's been a while, but could you set up a retest of this issue to ensure that Maxopoly's changes have fixed it?

Maxopoly commented 8 years ago

Just tried on CivTemp and it seemed to persist completly fine across restarts.

ProgrammerDan commented 8 years ago

Assuming this isn't an issue any longer, re-open if it is.

Maxopoly commented 8 years ago

https://github.com/Civcraft/NameLayer/pull/225 will completly remove group linking anyway

ProgrammerDan commented 8 years ago

Cool.