search

Civcraft / NameLayer

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/NameLayer
BSD 3-Clause "New" or "Revised" License
4 stars 14 forks source link

/nl -- Adding player to blacklist but give invalid player name #201

Closed ProgrammerDan closed 8 years ago

ProgrammerDan commented 8 years ago

image

As illustrated, giving a bad player name the prompt responds with "This group doesn't exist" which should likely be "This person has never played before" etc.

Maxopoly commented 8 years ago

I dont see how this could happen and cant reproduce http://puu.sh/pq0jP/12bef3074e.png

Are you sure that you didnt accidentally overlap this with another prompt which didnt have a message?

Maxopoly commented 8 years ago

After reading https://github.com/Civcraft/NameLayer/issues/202, I assume this issue is actually just another incarnation of https://github.com/Civcraft/NameLayer/issues/202

ProgrammerDan commented 8 years ago

99% confident. I'll see if I can give you a script to reproduce regularly later on.

I was consistently reproducing by canceling a prior prompt and beginning a different prompt of a different nature (group name vs player name). The second prompt would fail. On Jun 12, 2016 10:42 AM, "Maxopoly" notifications@github.com wrote:

I dont see how this could happen and cant reproduce http://puu.sh/pq0jP/12bef3074e.png

Are you sure that you didnt accidentally overlap this with another prompt which didnt have a message?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Civcraft/NameLayer/issues/201#issuecomment-225438678, or mute the thread https://github.com/notifications/unsubscribe/AAY-jq3WR9lSP2qFHX8VfYIDNZ9qw81oks5qLBrCgaJpZM4Izu8f .

ProgrammerDan commented 8 years ago

Ah yeah. Replying on mobile so lagging. Definitely an instance of 202. On Jun 12, 2016 10:46 AM, "Daniel Boston" programmerdan@gmail.com wrote:

99% confident. I'll see if I can give you a script to reproduce regularly later on.

I was consistently reproducing by canceling a prior prompt and beginning a different prompt of a different nature (group name vs player name). The second prompt would fail. On Jun 12, 2016 10:42 AM, "Maxopoly" notifications@github.com wrote:

I dont see how this could happen and cant reproduce http://puu.sh/pq0jP/12bef3074e.png

Are you sure that you didnt accidentally overlap this with another prompt which didnt have a message?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Civcraft/NameLayer/issues/201#issuecomment-225438678, or mute the thread https://github.com/notifications/unsubscribe/AAY-jq3WR9lSP2qFHX8VfYIDNZ9qw81oks5qLBrCgaJpZM4Izu8f .