search

Civcraft / NameLayer

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/NameLayer
BSD 3-Clause "New" or "Revised" License
4 stars 14 forks source link

Push login group loading to sync task #213

Closed suirad closed 8 years ago

suirad commented 8 years ago

This should give a speed increase to logins. It will put group loading on the next tick.

CivcraftBot commented 8 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

Maxopoly commented 8 years ago

You can actually remove that completly. It's a leftover from reinforcement decay (which was initially in NameLayer) and there is no good reason to preload all groups of a player.

suirad commented 8 years ago

Works for me. I'll swap it when I get back from getting food.

On Sat, Aug 13, 2016, 11:05 PM Maxopoly notifications@github.com wrote:

You can actually remove that completly. It's a leftover from reinforcement decay (which was initially in NameLayer) and there is no good reason to preload all groups of a player.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Civcraft/NameLayer/pull/213#issuecomment-239655083, or mute the thread https://github.com/notifications/unsubscribe-auth/AIZCbWKPs9fHhANNydC6Ztc2wFk8l0O8ks5qfpQHgaJpZM4Jj0eM .

ttk2 commented 8 years ago

So now we can just check for player group existence on first login and otherwise not touch groups on login?

suirad commented 8 years ago

Yes since they get loaded on first use and then cached

On Sun, Aug 14, 2016, 6:55 AM ttk2 notifications@github.com wrote:

So now we can just check for player group existence on first login and otherwise not touch groups on login?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Civcraft/NameLayer/pull/213#issuecomment-239669741, or mute the thread https://github.com/notifications/unsubscribe-auth/AIZCbUJUCbJIBsCHG3_G17dGZeMB-2UFks5qfwIcgaJpZM4Jj0eM .

suirad commented 8 years ago

Update commit, should be good to merge.