Closed goeppes closed 8 years ago
guh laptop cant look at files changed. I'll look into this. What else is changed besides just maven. A lot of file changes.
I moved the files around a lot, but the only source code that I touched was the NMS stuff, ClassHandler.java, and AssociationListener.java. The rest should pretty much just be pom stuff.
The "NMS to reflection" stuff isn't used, it's just that I forgot to switch branches before making changes and was too lazy to sort it out. It isn't present in the final code.
Can one of the admins verify this patch? Type 'ok to test' to test.
So I see no issues with this pull, although it might further delay the async PR. However, I'd honestly recommend this pull over the other, and I'd prefer to do async focusing instead of the calls that are for certain delay drivers instead of doing everything.
ok to build
ok to test
ty
:-/
What went wrong?
jenkins is broken currently, looking now at fixing.
retest this please
ok to test
ok to test
ok to test
ok to test
ok to test
ok to test
looks much better now :)
Maven is complaining about the use of variables; this pattern was removed in Maven 4 iirc.
I think it should be okay now.
http://build.civcraft.co/job/NameLayer-pull/86/console Yep, all good.
If no opposition, I'm going to merge this.
No opposition from my side
Done.
Someone probably needs to check this on their own test server to make sure nothing broke. That shouldn't be the case, but just to be safe. I would, but I can't set up a database server right now.