Civcraft / NameLayer

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/NameLayer
BSD 3-Clause "New" or "Revised" License
4 stars 14 forks source link

Maven fix #216

Closed goeppes closed 8 years ago

goeppes commented 8 years ago

Someone probably needs to check this on their own test server to make sure nothing broke. That shouldn't be the case, but just to be safe. I would, but I can't set up a database server right now.

rourke750 commented 8 years ago

guh laptop cant look at files changed. I'll look into this. What else is changed besides just maven. A lot of file changes.

goeppes commented 8 years ago

I moved the files around a lot, but the only source code that I touched was the NMS stuff, ClassHandler.java, and AssociationListener.java. The rest should pretty much just be pom stuff.

The "NMS to reflection" stuff isn't used, it's just that I forgot to switch branches before making changes and was too lazy to sort it out. It isn't present in the final code.

CivcraftBot commented 8 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

ProgrammerDan commented 8 years ago

So I see no issues with this pull, although it might further delay the async PR. However, I'd honestly recommend this pull over the other, and I'd prefer to do async focusing instead of the calls that are for certain delay drivers instead of doing everything.

ProgrammerDan commented 8 years ago

ok to build

Maxopoly commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

ty

Maxopoly commented 8 years ago

http://build.civcraft.co:8080/job/NameLayer-pull/77/console

rip

ProgrammerDan commented 8 years ago

:-/

goeppes commented 8 years ago

What went wrong?

ProgrammerDan commented 8 years ago

jenkins is broken currently, looking now at fixing.

ProgrammerDan commented 8 years ago

retest this please

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

looks much better now :)

Maven is complaining about the use of variables; this pattern was removed in Maven 4 iirc.

goeppes commented 8 years ago

I think it should be okay now.

ProgrammerDan commented 8 years ago

http://build.civcraft.co/job/NameLayer-pull/86/console Yep, all good.

ProgrammerDan commented 8 years ago

If no opposition, I'm going to merge this.

Maxopoly commented 8 years ago

No opposition from my side

ProgrammerDan commented 8 years ago

Done.