Limit usage of commands leading to direct database hits

Civcraft / NameLayer

Do not open issues here; open them on the maintained fork @ DevotedMC

https://github.com/DevotedMC/NameLayer

BSD 3-Clause "New" or "Revised" License

4 stars 14 forks source link

Limit usage of commands leading to direct database hits #223

Open ProgrammerDan opened 8 years ago

ProgrammerDan commented 8 years ago

Eliminate with prejudice, or at the very least rate limit its use.

Maxopoly commented 8 years ago

This doesn't apply only for nllm specifically, I only used it as an example. It's rather group managers behavior, where it will always attempt to load a group from the database, if it cant be found in the cache, so any commands with bogus group names will force a lookup in the db.

ProgrammerDan commented 8 years ago

Oh, well, failure to find is very lightweight. I thought from what you said that giving it a valid group name would force a recache.

I'm not very concerned about bogus data causing cache hits and DB checks, those are pretty fast. Still not a bad idea to rate limit though...