search

Civcraft / NameLayer

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/NameLayer
BSD 3-Clause "New" or "Revised" License
4 stars 14 forks source link

Using ManagedDatasource from CivModCore 1.5.0 #226

Closed ProgrammerDan closed 8 years ago

ProgrammerDan commented 8 years ago

This is a paired PR with CivModCore adddb PR.

Please review for any inaccuracies or missing changes.

Bungee, note, does not extend CivModCore and does not use the ManagedDatasource. Instead, I moved the generic "Database" handler that also uses HikariCP into Bungee-project and removed the dependency on Namelayer-Spigot from Namelayer-Bungee.

I also updated the plugin and bungee.yml's in this PR to have the release version instead of just 1.0.0.

ProgrammerDan commented 8 years ago

@Maxopoly been polishing this as I had energy today. I'll review your PR tomorrow and see about integrating the two; easier though for folks to review this un-integrated.

Maxopoly commented 8 years ago

Looks good overall, usage of the CivModCore stuff seems pretty straight forward. Nice job.

ProgrammerDan commented 8 years ago

Address all reviews, including making properties.releaseVersion the only thing needing updating on new version increment.

ProgrammerDan commented 8 years ago

ok to test

ProgrammerDan commented 8 years ago

Any objection to my merging this in? I'll work on integrating it in to your PR @Maxopoly

Maxopoly commented 8 years ago

No objections