Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

Adminbanned players get altbanned message on login #101

Closed Maxopoly closed 8 years ago

Maxopoly commented 8 years ago

https://github.com/Civcraft/PrisonPearl/blob/master/src/vg/civcraft/mc/prisonpearl/managers/ban/CBanManager.java#L28

Maxopoly commented 8 years ago

You could give your ban check MONITOR priority, so it's guaranteed after CBan check.

rourke750 commented 8 years ago

Lol max no, never ever set any state of anything using monitor. We can just remove the kick message https://github.com/Civcraft/PrisonPearl/blob/master/src/vg/civcraft/mc/prisonpearl/listener/BanListener.java#L52 there since cbanmanagement will handle it.

Maxopoly commented 8 years ago

Hmm alright. What's so bad about monitor?

ProgrammerDan commented 8 years ago

MONITOR should never alter the event they receive...

rourke750 commented 8 years ago

https://github.com/Civcraft/PrisonPearl/commit/38376b0929374c6266a022ffed7075e88a49b062