search

Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

Pearl alt-ban ordering #11

Closed erocs closed 10 years ago

erocs commented 10 years ago

In this case, the alt list has 3 players. To start, two are pearled and the third is properly banned. Then one of the pearls is released. The banned account remains banned. It looks like the ordering of ban checks against the accounts when a pearl is freed might be wrong.

2014-09-30 00:00:00 [INFO] [PrisonPearl] checking 00000000-1111-0000-0000-000000000000 2014-09-30 00:00:00 [INFO] [PrisonPearl] banning 00000000-1111-0000-0000-000000000000, for having 2 imprisoned alts: 00000000-2222-0000-0000-000000000000, 00000000-3333-0000-0000-000000000000 2014-09-30 00:00:00 [INFO] [PrisonPearl] checking 00000000-3333-0000-0000-000000000000 2014-09-30 00:00:00 [INFO] [PrisonPearl] 00000000-1111-0000-0000-000000000000 still banned for having 2 imprisoned alts: 00000000-2222-0000-0000-000000000000, 00000000-3333-0000-0000-000000000000 2014-09-30 00:00:00 [INFO] [PrisonPearl] ABC(00000000-2222-0000-0000-000000000000) is being freed. Reason: XYZ threw the pearl.

rourke750 commented 10 years ago

Where is this coming from? https://github.com/Civcraft/PrisonPearl/blob/master/src/com/untamedears/PrisonPearl/PrisonPearlPlugin.java#L922 that line is commented out.

rourke750 commented 10 years ago

anyways changed the order of the banning https://github.com/Civcraft/PrisonPearl/commit/3aace728af5dd9edbcb379113a9781445500c35b

Have it delete pearl first and then it runs straight to unpearling the player.

rourke750 commented 10 years ago

unfortunately the player will not be unbanned. Use the commands to manually unban the player. From then on after it should auto fix anything else.