search

Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

Prevent Prisoners from holding PrisonPearls #12

Closed erocs closed 9 years ago

erocs commented 9 years ago

Consider this potential feature. It would make sense and remove a long distance 'teleportation' loophole.

ttk2 commented 9 years ago

How does this work again? Player takes a pearl to the end hands it to another prisoner who is summoned back and can then free the player at an arbitrary location? On Oct 16, 2014 12:12 PM, "erocs" notifications@github.com wrote:

Consider this potential feature. It would make sense and remove a long distance 'teleportation' loophole.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/12.

erocs commented 9 years ago

https://www.reddit.com/r/Civcraft/comments/2jfg7d/civcraft_changelog_for_20141016/clb810a

Yeah. Pearls are the only things that transfer from the end back to the overworld. I'm not sure this works, but it should be verified.

ttk2 commented 9 years ago

I thought we blocked bringing anything back but pears? maybe that's whats broken?

On Thu, Oct 16, 2014 at 2:05 PM, erocs notifications@github.com wrote:

https://www.reddit.com/r/Civcraft/comments/2jfg7d/civcraft_changelog_for_20141016/clb810a

Yeah. Pearls are the only things that transfer from the end back to the overworld. I'm not sure this works, but it should be verified.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/12#issuecomment-59413159.

rourke750 commented 9 years ago

it doesnt check for lore so any kind of pearl is fine.

ttk2 commented 9 years ago

if we where going to stop prisoners from holding prisonpearls how would we prevent them from doing so?

On Fri, Oct 17, 2014 at 8:19 AM, rourke750 notifications@github.com wrote:

it doesnt check for lore so any kind of pearl is fine.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/12#issuecomment-59511046.

rourke750 commented 9 years ago

We can see if the player is pearled and if so cancel the pick up event. On Oct 17, 2014 7:37 PM, "ttk2" notifications@github.com wrote:

if we where going to stop prisoners from holding prisonpearls how would we prevent them from doing so?

On Fri, Oct 17, 2014 at 8:19 AM, rourke750 notifications@github.com wrote:

it doesnt check for lore so any kind of pearl is fine.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/12#issuecomment-59511046.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/12#issuecomment-59589478.

erocs commented 9 years ago

Also inventory move event. On Oct 17, 2014 4:39 PM, "rourke750" notifications@github.com wrote:

We can see if the player is pearled and if so cancel the pick up event. On Oct 17, 2014 7:37 PM, "ttk2" notifications@github.com wrote:

if we where going to stop prisoners from holding prisonpearls how would we prevent them from doing so?

On Fri, Oct 17, 2014 at 8:19 AM, rourke750 notifications@github.com wrote:

it doesnt check for lore so any kind of pearl is fine.

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/PrisonPearl/issues/12#issuecomment-59511046>.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/12#issuecomment-59589478.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/12#issuecomment-59589607.

rourke750 commented 9 years ago

Fixed: https://github.com/Civcraft/PrisonPearl/commit/d54c59155e6bcaf66e7dd3ee131cfc46b96c7844