search

Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

Add information to pearls and fix stuff on the way #144

Closed Maxopoly closed 8 years ago

Maxopoly commented 8 years ago

Rework flatfile saving to use yml, add killer and death time to pearls and storage, improve usage of interfaces to no longer duplicate code

Untested so far, but will test before merging

CivcraftBot commented 8 years ago

Can one of the admins verify this patch? Type 'ok to test' to test.

Maxopoly commented 8 years ago

No comment means I can merge and do whatever I want?

ProgrammerDan commented 8 years ago

Probably :P

@rourke750 Anything?

@Maxopoly How'd testing go?

Maxopoly commented 8 years ago

Ok, this is completly tested and both flatfile and sql are working with all of this. While I was on it I also fixed a ton of issues with flatfile storage, it was barely functional.

Unless there are any objections, I'd say we merge this.

ProgrammerDan commented 8 years ago

If you've tested it I see no issues here, code looks clean, good refactors.