search

Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

/ppf should spawn the player in the overworld where they were freed if they were online when freed. #149

Open idoash4 opened 8 years ago

rourke750 commented 8 years ago

What currently happens?

idoash4 commented 8 years ago

they are killed and random spawn.

idoash4 commented 8 years ago

Let me actually try this again on a local server. It is possible the event I am referring to was caused because the player was already in death screen when freed.

rourke750 commented 8 years ago

Did you check the config? I think that's a config option.

idoash4 commented 8 years ago

Yes it is set to true.

Also I think teleporting the player to the end shard is broken in sharded servers as well. I couldn't get it to work locally. Both the server name and the world were set in the config. I think the problem is here: https://github.com/Civcraft/PrisonPearl/blob/master/src/vg/civcraft/mc/prisonpearl/managers/PrisonPearlManager.java#L345

This method should return a random location to spawn a player in the prison world but it looks like it will just give a random location that can be everywhere.

rourke750 commented 8 years ago

It always worked when I tested it. I'll look I to this again. also for the config option shouldn't it be false.

idoash4 commented 8 years ago

it is named free_tppearl so I don't think so.

idoash4 commented 8 years ago

Also some of the code was changed in this commit: https://github.com/Civcraft/PrisonPearl/commit/f8dadfeaa98336095ec810095260debe53384959

I don't think any testing was done on a sharded server after this commit.

ProgrammerDan commented 8 years ago

@BlackXnt nothing changed in that commit that would impact Sharded servers. Most of the changes in that specific commit where whitespace fixes.

The additional spawning logic is for non-sharded servers only (note that if sharding is enabled, the new code added isn't run at all). Etc.

rourke750 commented 8 years ago

Is this still occurring?