search

Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

Prevent Loaded Pearls Being Free'd #17

Closed Ty4Code closed 9 years ago

Ty4Code commented 9 years ago

Fixes issue Civcraft/PrisonPearl#15. Prevents previously unloaded pearls from being free'd/expired even if the chunk has been reloaded.

ttk2 commented 9 years ago

what exactly was the issue?

On Wed, Nov 19, 2014 at 4:04 PM, MrTwiggy notifications@github.com wrote:

Fixes issue Civcraft/PrisonPearl#15 https://github.com/Civcraft/PrisonPearl/issues/15. Prevents previously unloaded pearls

from being free'd/expired even if the chunk has been reloaded.

You can merge this Pull Request by running

git pull https://github.com/MrTwiggy/PrisonPearl master

Or view, comment on, or merge it at:

https://github.com/Civcraft/PrisonPearl/pull/17 Commit Summary

  • Prevent Loaded Pearls Being Free'd

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/17.

Ty4Code commented 9 years ago

The issue was that if a prison pearl was dropped on the ground, and then the chunk that the pearl was inside was unloaded. The pearl was added to a list, and after a certain delay, the pearl was "free'd" and destroyed, regardless of whether the chunk was re-loaded again.

ttk2 commented 9 years ago

ah, so this just cancels the event on reload. Strange I remember a pull to fix that earlier.

On Wed, Nov 19, 2014 at 4:11 PM, MrTwiggy notifications@github.com wrote:

The issue was that if a prison pearl was dropped on the ground, and then the chunk that the pearl was inside was unloaded. The pearl was added to a list, and after a certain delay, the pearl was "free'd" and destroyed, regardless of whether the chunk was re-loaded again.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/17#issuecomment-63723792.

rourke750 commented 9 years ago

@ttk2 Its a little different. Anyways code is good so I'm merging. Check for a new jar on jenkins and this can go live without testing.