Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

If jailer issues /ppk too soon after player login (< 1 second), damage is ignored and player is not returned to the end #176

Closed ProgrammerDan closed 8 years ago

ProgrammerDan commented 8 years ago

https://github.com/Civcraft/PrisonPearl/blob/master/src/vg/civcraft/mc/prisonpearl/command/commands/Kill.java#L49

Apparently there is a short invulnerability period in Minecraft on player join -- perhaps half a second? Essentials allows this to be configured, but I can't find any default way to configure it.

In any case, if a jailer wishing to return his truant prisoner issues /ppk during this time period, they get a successful message but the prisoner is not killed and not returned to the end, due to the use of "vanilla" damage methods, which quietly drop the damage while a player is invulnerable.

This is an exploit, and a bug.

rourke750 commented 8 years ago

Fixed waiting for next commit.

rourke750 commented 8 years ago

https://github.com/Civcraft/PrisonPearl/pull/174

rourke750 commented 8 years ago

Fixed