search

Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

Hopefully this adds the information you needed #27

Closed spaceFountain closed 9 years ago

spaceFountain commented 9 years ago

I ended up probably adding more information than you really need an in a bit of a strange way. HolderVerReason can probably be removed, but I figured it didn't do any harm and might help at some point.

Basically this does two things.

  1. Adds logging to verifyHolder in the case of success
  2. Has verifyLocation record the log even in the case of success.

In the course of misunderstanding what the issue was I also had verifyHolder return a enum describing the reason for verification or failure which is added to the log messages.

This has not been tested beyond compiling as I don't have multiple people to test with. It should work properly, but I can't be sure.

rourke750 commented 9 years ago

Look's awesome thx a lot for this

ttk2 commented 9 years ago

should I put the pp version on Civtest on Civcraft?

On Sat Jan 24 2015 at 2:08:59 PM rourke750 notifications@github.com wrote:

Look's awesome thx a lot for this

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335023.

rourke750 commented 9 years ago

Put it on the citadel one. On Jan 24, 2015 3:14 PM, "ttk2" notifications@github.com wrote:

should I put the pp version on Civtest on Civcraft?

On Sat Jan 24 2015 at 2:08:59 PM rourke750 notifications@github.com wrote:

Look's awesome thx a lot for this

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335023.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335277.

ttk2 commented 9 years ago

the jar on Civtest is specifically labeled for citadel 2.0 should I just pull off of Jenkins instead?

On Sat Jan 24 2015 at 2:15:44 PM rourke750 notifications@github.com wrote:

Put it on the citadel one. On Jan 24, 2015 3:14 PM, "ttk2" notifications@github.com wrote:

should I put the pp version on Civtest on Civcraft?

On Sat Jan 24 2015 at 2:08:59 PM rourke750 notifications@github.com wrote:

Look's awesome thx a lot for this

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335023.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335277.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335303.

rourke750 commented 9 years ago

The civtest one can go on Civcraft if you are not updating to citadel 3.0 tomorrow. This one is being built on jenkins should go on the citadel 3.0 test server On Jan 24, 2015 3:19 PM, "ttk2" notifications@github.com wrote:

the jar on Civtest is specifically labeled for citadel 2.0 should I just pull off of Jenkins instead?

On Sat Jan 24 2015 at 2:15:44 PM rourke750 notifications@github.com wrote:

Put it on the citadel one. On Jan 24, 2015 3:14 PM, "ttk2" notifications@github.com wrote:

should I put the pp version on Civtest on Civcraft?

On Sat Jan 24 2015 at 2:08:59 PM rourke750 notifications@github.com wrote:

Look's awesome thx a lot for this

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335023>.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335277.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335303.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335426.

ttk2 commented 9 years ago

updated PP on the 3.0 testing server, staged new pp on Civcraft

On Sat Jan 24 2015 at 2:29:09 PM rourke750 notifications@github.com wrote:

The civtest one can go on Civcraft if you are not updating to citadel 3.0 tomorrow. This one is being built on jenkins should go on the citadel 3.0 test server On Jan 24, 2015 3:19 PM, "ttk2" notifications@github.com wrote:

the jar on Civtest is specifically labeled for citadel 2.0 should I just pull off of Jenkins instead?

On Sat Jan 24 2015 at 2:15:44 PM rourke750 notifications@github.com wrote:

Put it on the citadel one. On Jan 24, 2015 3:14 PM, "ttk2" notifications@github.com wrote:

should I put the pp version on Civtest on Civcraft?

On Sat Jan 24 2015 at 2:08:59 PM rourke750 notifications@github.com

wrote:

Look's awesome thx a lot for this

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335023>.

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335277>.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335303.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335426.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71335822.

spaceFountain commented 9 years ago

Just make sure someone gets on the test server to do at least some basic testing before this goes live. There's no reason it shouldn't work, but if I got something wrong there's the potential for it to lead to pearls getting freed. I'll be busy with school stuff till probably after dinner, but I can hop on then if anyone's will to pearl me. When does verifyLocation() get called? Just on restart or anytime someone checks where their pearl is being held?

ttk2 commented 9 years ago

I think both, let me test it

On Sat Jan 24 2015 at 2:58:53 PM spaceFountain notifications@github.com wrote:

Just make sure someone gets on the test server to do at least some basic testing before this goes live. There's no reason it shouldn't work, but if I got something wrong there's the potential for it to lead to pearls getting freed. I'll be busy with school stuff till probably after dinner, but I can hop on then if anyone's will to pearl me. When does verifyLocation() get called? Just on restart or anytime someone checks where their pearl is being held?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71336960.

ttk2 commented 9 years ago

tested, worked just fine, pearled, summoned, returned, restarted, fed

On Sat Jan 24 2015 at 6:38:42 PM justin kilpatrick < kilpatrickjustin@gmail.com> wrote:

I think both, let me test it

On Sat Jan 24 2015 at 2:58:53 PM spaceFountain notifications@github.com wrote:

Just make sure someone gets on the test server to do at least some basic testing before this goes live. There's no reason it shouldn't work, but if I got something wrong there's the potential for it to lead to pearls getting freed. I'll be busy with school stuff till probably after dinner, but I can hop on then if anyone's will to pearl me. When does verifyLocation() get called? Just on restart or anytime someone checks where their pearl is being held?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/27#issuecomment-71336960.