Alt-ban logging

[erocs]

Add a log of the number of bans loaded in BanManager.loadBanJournal. Log a player's ban state as its seen by BanManager.onPlayerLogin.

[jjj5311]

Do you want to log all players ban states? or only those who are banned

[ttk2]

only those who are banned, all players is just too much

On Thu, Feb 26, 2015 at 7:22 AM jjj5311 notifications@github.com wrote:

Do you want to log all players ban states? or only those who are banned

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76176794.

[erocs]

Any player who logs in I'd like to get a status reported out of that async event for what decision it's making. We'd probably tone it down later.

Scenario, player logs in who should be alt banned but isn't denied and can play. Confirmed there are two pearls for other accounts on the alt list. The ban journal states the account is alt banned. Is there a login state other then allowed that let them on? Did the async event not finish fast enough to prevent the login? On Feb 26, 2015 7:05 AM, "ttk2" notifications@github.com wrote:

only those who are banned, all players is just too much

On Thu, Feb 26, 2015 at 7:22 AM jjj5311 notifications@github.com wrote:

Do you want to log all players ban states? or only those who are banned

— Reply to this email directly or view it on GitHub <https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76176794 .

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76193305.

[jjj5311]

Hmmm... i came up with a little bit of logging but not sure if the way i am doing it is good and/or if this is the right info.

You can see it on my fix-33 branch

https://github.com/jjj5311/PrisonPearl/tree/fix-33

Here is the file outputs... is this what you want?

https://gist.github.com/jjj5311/8b693d8bad69c549dff9

[erocs]

You don't need to do all the file stuff. Just use PrisonPearlPlugin.log() to log the entries into the server log.

One thing I'm curious about. Are there other enum values that allow a login making this statement too permissive. if (event.getLoginResult() != AsyncPlayerPreLoginEvent.Result.ALLOWED)

The rest you've logged is good, Alt-ban state vs. game-ban state. We probably don't need to worry about ALLOW LOGIN and DENY LOGIN as we can figure that out from the two ban states.

On Thu, Feb 26, 2015 at 3:59 PM, jjj5311 notifications@github.com wrote:

Hmmm... i came up with a little bit of logging but not sure if the way i am doing it is good and/or if this is the right info.

You can see it on my fix-33 branch

https://github.com/jjj5311/PrisonPearl/tree/fix-33

Here is the file outputs... is this what you want?

https://gist.github.com/jjj5311/8b693d8bad69c549dff9

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76302288.

[jjj5311]

Okay sounds good I should be able to do that a little later

On Thursday, February 26, 2015, erocs notifications@github.com wrote:

You don't need to do all the file stuff. Just use PrisonPearlPlugin.log() to log the entries into the server log.

One thing I'm curious about. Are there other enum values that allow a login making this statement too permissive. if (event.getLoginResult() != AsyncPlayerPreLoginEvent.Result.ALLOWED)

The rest you've logged is good, Alt-ban state vs. game-ban state. We probably don't need to worry about ALLOW LOGIN and DENY LOGIN as we can figure that out from the two ban states.

On Thu, Feb 26, 2015 at 3:59 PM, jjj5311 <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Hmmm... i came up with a little bit of logging but not sure if the way i am doing it is good and/or if this is the right info.

You can see it on my fix-33 branch

https://github.com/jjj5311/PrisonPearl/tree/fix-33

Here is the file outputs... is this what you want?

https://gist.github.com/jjj5311/8b693d8bad69c549dff9

— Reply to this email directly or view it on GitHub <https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76302288 .

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76307170.

[erocs]

Thanks! Ttk2 let's stage this.

Also aeecea62

[ttk2]

stage the new jar or the version currently on Civtest?

On Sun, Mar 1, 2015 at 4:16 PM erocs notifications@github.com wrote:

Thanks! Ttk2 let's stage this.

Also aeecea6 https://github.com/Civcraft/PrisonPearl/commit/aeecea6228ac1079e1b29b4ffefe5f8d65434872

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76634517.

[erocs]

New jar to CivTest / CivCraft (if this is the only change that would be pushed to the main server)

On Sun, Mar 1, 2015 at 2:39 PM, ttk2 notifications@github.com wrote:

stage the new jar or the version currently on Civtest?

On Sun, Mar 1, 2015 at 4:16 PM erocs notifications@github.com wrote:

Thanks! Ttk2 let's stage this.

Also aeecea6 < https://github.com/Civcraft/PrisonPearl/commit/aeecea6228ac1079e1b29b4ffefe5f8d65434872

— Reply to this email directly or view it on GitHub <https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76634517 .

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76635729.

[ttk2]

updated on civtest

On Sun, Mar 1, 2015 at 6:18 PM erocs notifications@github.com wrote:

New jar to CivTest / CivCraft (if this is the only change that would be pushed to the main server)

On Sun, Mar 1, 2015 at 2:39 PM, ttk2 notifications@github.com wrote:

stage the new jar or the version currently on Civtest?

On Sun, Mar 1, 2015 at 4:16 PM erocs notifications@github.com wrote:

Thanks! Ttk2 let's stage this.

Also aeecea6 <

https://github.com/Civcraft/PrisonPearl/commit/aeecea6228ac1079e1b29b4ffefe5f8d65434872

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76634517 .

— Reply to this email directly or view it on GitHub <https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76635729 .

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76640512.

[ttk2]

is this ready to go online

[ttk2]

is this ready to go online?

[erocs]

Yes, I don't know if there have been any other PP changes that haven't gone to the main server yet though.

[ttk2]

there does not seem to be anything of exceptional import, just pearl someone and make sure that works I guess

On Mon, Mar 2, 2015 at 11:48 PM erocs notifications@github.com wrote:

Yes, I don't know if there have been any other PP changes that haven't gone to the main server yet though.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76890914.

[jjj5311]

It should only log their ban status and a few other things

On Tuesday, March 3, 2015, ttk2 notifications@github.com wrote:

there does not seem to be anything of exceptional import, just pearl someone and make sure that works I guess

On Mon, Mar 2, 2015 at 11:48 PM erocs <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Yes, I don't know if there have been any other PP changes that haven't gone to the main server yet though.

— Reply to this email directly or view it on GitHub <https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76890914 .

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-77076734.

[ttk2]

a few other changes are inbetween this and the currently running version, so some testing is required.

On Tue, Mar 3, 2015 at 7:03 PM jjj5311 notifications@github.com wrote:

It should only log their ban status and a few other things

On Tuesday, March 3, 2015, ttk2 notifications@github.com wrote:

there does not seem to be anything of exceptional import, just pearl someone and make sure that works I guess

On Mon, Mar 2, 2015 at 11:48 PM erocs <notifications@github.com javascript:_e(%7B%7D,'cvml','notifications@github.com');> wrote:

Yes, I don't know if there have been any other PP changes that haven't gone to the main server yet though.

— Reply to this email directly or view it on GitHub < https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-76890914 .

— Reply to this email directly or view it on GitHub <https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-77076734 .

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/33#issuecomment-77076925.

[jjj5311]

This can be closed right?