search

Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

PrisonPearl rewrite using uuids as the identifying factor instead of damage value. #60

Closed rourke750 closed 8 years ago

rourke750 commented 9 years ago

Basically prison pearl differentiates the pearls based on what their damage value is. This is no longer a viable solution. We need to move it over to identifying pearls by its first line of lore which should be its uuid.

@gipsy-king I'm assigning you to do this, is that okay?

ProgrammerDan commented 9 years ago

'tis a big one. Apparently we've got what, two tiers of backwards compatibility to maintain unless we can upconvert all pearls? (pre-uuid pearls, post-uuid pearls, and with this, lored pearls)

rourke750 commented 9 years ago

Well you just add another step to the preexisting script. On Jul 23, 2015 3:28 PM, "Daniel Boston" notifications@github.com wrote:

'tis a big one. Apparently we've got what, two tiers of backwards compatibility to maintain unless we can upconvert all pearls? (pre-uuid pearls, post-uuid pearls, and with this, lored pearls)

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/60#issuecomment-124218195 .

ttk2 commented 9 years ago

prisonpearl should touch every pearl every restart thanks to pearl feeding, anyone running prisonpearl recently should have all their pearls on the latest version, unless we want to care about people jumping from really old PP to modern PP without any issues.

ProgrammerDan commented 9 years ago

Meant by my comment that I've got reports from sources ;) that some of their pearls are so old they don't have UUID's. Meaning active pearls on Civcraft currently span versions.

rourke750 commented 9 years ago

That's just the lore, good catch though. Need to make sure that it is actually there. On Jul 23, 2015 8:22 PM, "Daniel Boston" notifications@github.com wrote:

Meant by my comment that I've got reports from Eden that some of their pearls are so old they don't have UUID's. Meaning actively pearls on Civcraft currently span versions.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/60#issuecomment-124275760 .

ttk2 commented 9 years ago

shouldn't the pearl be updated when they pick it up?

rourke750 commented 9 years ago

@gipsy-king how goes this?

ttk2 commented 9 years ago

Not really apparently.

benjajaja commented 9 years ago

didn't look into PP at all, sorry for not telling you.

rourke750 commented 9 years ago

NP. I'll start it if you'd rather me. On Aug 8, 2015 8:17 AM, "Benjamin Grosse" notifications@github.com wrote:

didn't look into PP at all, sorry for not telling you.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/60#issuecomment-128972543 .

benjajaja commented 9 years ago

@rourke750 yeah I checked it out and I don't really understand most of PP.

erocs commented 9 years ago

Status? Isn't this live?

ttk2 commented 9 years ago

it died, I think roruke fixed it but I have not tried again since the last debacle.

ttk2 commented 9 years ago

@rourke750 did you make any improvements here? Should we try again?

ttk2 commented 9 years ago

just tried again on a local copy, another failure, here is the stack.

[12:17:24 ERROR]: Error occurred while enabling PrisonPearl v2.5.5 (Is it up to date?) java.lang.ArrayIndexOutOfBoundsException: 3 at com.untamedears.PrisonPearl.PrisonPearlStorage.load(PrisonPearlStorage.java:106) ~[?:?] at com.untamedears.PrisonPearl.PrisonPearlPlugin.load(PrisonPearlPlugin.java:429) ~[?:?] at com.untamedears.PrisonPearl.PrisonPearlPlugin.onEnable(PrisonPearlPlugin.java:129) ~[?:?] at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:321) ~[spigot.jar:git-Spigot-d97e08b-880a532] at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader.java:340) [spigot.jar:git-Spigot-d97e08b-880a532] at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManager.java:405) [spigot.jar:git-Spigot-d97e08b-880a532] at org.bukkit.craftbukkit.v1_8_R3.CraftServer.loadPlugin(CraftServer.java:357) [spigot.jar:git-Spigot-d97e08b-880a532] at org.bukkit.craftbukkit.v1_8_R3.CraftServer.enablePlugins(CraftServer.java:317) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.MinecraftServer.s(MinecraftServer.java:414) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.MinecraftServer.k(MinecraftServer.java:378) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.MinecraftServer.a(MinecraftServer.java:333) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.DedicatedServer.init(DedicatedServer.java:263) [spigot.jar:git-Spigot-d97e08b-880a532] at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java:524) [spigot.jar:git-Spigot-d97e08b-880a532] at java.lang.Thread.run(Thread.java:745) [?:1.8.0_51]

erocs commented 9 years ago

@rourke750 status?