Player Death add respect for combat tag if CT or CTP is enabled

[ProgrammerDan]

Players are getting "pearled" by non-combat deaths long after combat has ended. Easiest fix to me seems to just add respect for combat tag and remove total reliance on the damagetracker. Seems the damagetracker isn't releasing damage events appropriately; so later we can tackle root cause.

Addresses issue #74

[CivcraftBot]

Can one of the admins verify this patch? Type 'ok to test' to test.

[ProgrammerDan]

ok to test

[ProgrammerDan]

@rourke750 or @Maxopoly can I get some eyes on this and a test build? The pom dependencies are a frickin' mess in this plugin, so contrary my usual I'm submitting this pull blind.

[rourke750]

ok to test

[ProgrammerDan]

oooor triggers aren't working, sigh.

[ProgrammerDan]

@Maxopoly do you have it setup to build locally?

@rourke750 any chance my account on the build server could get admin so I could fix some of these build jobs? Been using Jenkins for years, I could be an asset.

[rourke750]

What's your account.

[rourke750]

ok to test

[ProgrammerDan]

It's ProgrammerDan -- i'm nothing if not consistent :D

[rourke750]

Jar built

[rourke750]

@ProgrammerDan you have jenkins perms now.

[ProgrammerDan]

Looks like you have it pretty segmented, not seeing any configuration controls on any active projects. Do see some new options on prior builds (redeployment options, etc.)

[ttk2]

give the man full access.

[ttk2]

hell he can have ssh into the machine if he wants.

[rourke750]

@ProgrammerDan try now, i had missed some.

[ProgrammerDan]

Alright, build is live on Civtest Pepper.

[ProgrammerDan]

had a few players test it for me on civtest, works as desired:

• Death by any means while combat-tagged after taking damage results in the pearl being awarded
• Death by non-PVP means after combat-tag has expired regardless of damage dealt results in no pearl, just death.

[ProgrammerDan]

@ttk2 @rourke750 @erocs @drjawa Any objections / discussion, or safe to merge?

[ttk2]

merge and I will stage immediately thereafter.

On Thu, Nov 12, 2015 at 10:24 AM, Daniel Boston notifications@github.com wrote:

@ttk2 https://github.com/ttk2 @rourke750 https://github.com/rourke750 @erocs https://github.com/erocs @drjawa https://github.com/drjawa Any objections / discussion, or safe to merge?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/75#issuecomment-156155093.

[rourke750]

Give me a min to look at it.

[ProgrammerDan]

Ah woops. Feel free to rollback if you see something undesired.

[rourke750]

Youre good you did exactly what I was checking for. Just making sure we are up keeping the softdepdency.

[ProgrammerDan]

Yeah, definitely.

Only thing I didn't do is up the version number on the plugin. If you want I can do that real quick-like -- always forget, shame on me.

[erocs]

Rourke never does. No worries, you're on par.

Not sure this needed a <24hr fix as it wasn't really P0, meh.

[ProgrammerDan]

5 people were impacted by this yesterday after fighting had ended when a creeper blew them up, then they were vaulted.

That's why. Sure, modmail can free them, but I'd prefer to save you any future volume.

[erocs]

shrug The 'bug' has existed for 4 years and only now when it's strategic is the sky falling.

[ttk2]

that's how things always work, anyways new build staged.

On Thu, Nov 12, 2015 at 11:58 AM, erocs notifications@github.com wrote:

shrug The 'bug' has existed for 4 years and only now when it's strategic is the sky falling.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/pull/75#issuecomment-156184308.

[ProgrammerDan]

Point well made, however this is the first I personally knew of it. Woulda addressed it long ago, regardless of who reported it, had I known.

Also, we're in Ragnarok mode. Player death is way more common right now, coinciding with large-scale open warfare ... I don't want anyone else to get the shaft from this.

[erocs]

ACK, good to fix at any rate.