Civcraft / PrisonPearl

Minecraft plugin for civcraft which allows players to imprison other players inside ender pearls
BSD 3-Clause "New" or "Revised" License
4 stars 16 forks source link

New commands #9

Closed erocs closed 10 years ago

erocs commented 10 years ago

Please add /ppban and /ppunban to manage PP's ban list. Yes people could just become re-banned due to an alt list, but these will be useful at times.

Also a /ppgetalts to report PP's current view of a player or account's alt list.

rourke750 commented 10 years ago

I was thinking of ppgetalts. Wouldn't that just pull from misc log if it wasn't dealing with the alts before though? I'm guessing just for sub admins.

erocs commented 10 years ago

Just wanting a way to introspect what PP has cached from the alt plugin. That way we could remove the accounts from the debug spew and not slow down the server printing out huge lists.

On Mon, Sep 29, 2014 at 3:13 PM, rourke750 notifications@github.com wrote:

I was thinking of ppgetalts. Wouldn't that just pull from misc log if it wasn't dealing with the alts before though? I'm guessing just for sub admins.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#issuecomment-57238873.

rourke750 commented 10 years ago

I'm curious how you do it because with mine it was never slow. Is it just because there is so much more data with yours?

erocs commented 10 years ago

Printing out lists of 1200 players takes a while...

On Mon, Sep 29, 2014 at 3:17 PM, rourke750 notifications@github.com wrote:

I'm curious how you do it because with mine it was never slow. Is it just because there is so much more data with yours?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#issuecomment-57239310.

rourke750 commented 10 years ago

1 player has over 1200 associations?

erocs commented 10 years ago

There isn't "1 player has x associations". There's at least one 1200 player alt list.

On Mon, Sep 29, 2014 at 3:34 PM, rourke750 notifications@github.com wrote:

1 player has over 1200 associations?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#issuecomment-57241093.

rourke750 commented 10 years ago

How, how does that happen?

erocs commented 10 years ago

Doesn't matter. So yes, I was just wanting this command to dump out the cached alt list for a given player. It shouldn't query for a new list if it doesn't have one or to refresh the current one.

On Mon, Sep 29, 2014 at 3:36 PM, rourke750 notifications@github.com wrote:

How, how does that happen?

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#issuecomment-57241294.

rourke750 commented 10 years ago

looks like ppgetalts was already there

erocs commented 10 years ago

Cool, did it pull from the old alts.txt or use the in-memory cache?

On Mon, Sep 29, 2014 at 3:47 PM, rourke750 notifications@github.com wrote:

looks like ppgetalts was already there

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#issuecomment-57242324.

rourke750 commented 10 years ago

it used to pull but I added caching for something else.

rourke750 commented 10 years ago

https://github.com/Civcraft/PrisonPearl/commit/28d46c053064f4eeecf54e40e615e6866ec4291c

erocs commented 10 years ago

I wasn't thinking to ban / unban the entire alt list, but just individual players. Hrm, let's work with this and see if it's enough. I can reopen this later if we need individual ban/pardon.

On Mon, Sep 29, 2014 at 4:34 PM, rourke750 notifications@github.com wrote:

Closed #9 https://github.com/Civcraft/PrisonPearl/issues/9.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#event-171805654.

rourke750 commented 10 years ago

unbanning / banning individuals is a bit more work since as soon as they were to log in they would just get rebanned here: https://github.com/Civcraft/PrisonPearl/blob/master/src/com/untamedears/PrisonPearl/PrisonPearlPlugin.java#L449

On Mon, Sep 29, 2014 at 7:36 PM, erocs notifications@github.com wrote:

I wasn't thinking to ban / unban the entire alt list, but just individual players. Hrm, let's work with this and see if it's enough. I can reopen this later if we need individual ban/pardon.

On Mon, Sep 29, 2014 at 4:34 PM, rourke750 notifications@github.com wrote:

Closed #9 https://github.com/Civcraft/PrisonPearl/issues/9.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#event-171805654.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#issuecomment-57246840.

erocs commented 10 years ago

Good point. Of course, unbanning the entire list will achieve the same thing with their next login. This should be fine as it is only supposed to be an emergency measure if we think they weren't properly banned or unbanned via PP.

On Mon, Sep 29, 2014 at 4:38 PM, rourke750 notifications@github.com wrote:

unbanning / banning individuals is a bit more work since as soon as they were to log in they would just get rebanned here:

https://github.com/Civcraft/PrisonPearl/blob/master/src/com/untamedears/PrisonPearl/PrisonPearlPlugin.java#L449

On Mon, Sep 29, 2014 at 7:36 PM, erocs notifications@github.com wrote:

I wasn't thinking to ban / unban the entire alt list, but just individual players. Hrm, let's work with this and see if it's enough. I can reopen this later if we need individual ban/pardon.

On Mon, Sep 29, 2014 at 4:34 PM, rourke750 notifications@github.com wrote:

Closed #9 https://github.com/Civcraft/PrisonPearl/issues/9.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#event-171805654.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#issuecomment-57246840.

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/PrisonPearl/issues/9#issuecomment-57246938.