search

Civcraft / RealisticBiomes

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/RealisticBiomes
7 stars 14 forks source link

Main class should not be a listener. Removed unneeded code. #17

Closed plebes closed 9 years ago

plebes commented 9 years ago

The main RealisticBiomes class was implementing Listener, and registering itself as a listener, but it doesn't actually have listening events that it handles. The code seems superfluous, unless I missed something.

ttk2 commented 9 years ago

I will have this reviewed, but if its right good job.

On Fri, May 29, 2015 at 10:11 PM plebes notifications@github.com wrote:

The main RealisticBiomes class was implementing Listener, and registering itself as a listener, but it doesn't actually have listening events that it

handles. The code seems superfluous, unless I missed something.

You can view, comment on, or merge this pull request online at:

https://github.com/Civcraft/RealisticBiomes/pull/17 Commit Summary

  • Main class should not be a listener. Removed unneeded code.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/pull/17.

WildWeazel commented 9 years ago

good catch

ProgrammerDan commented 9 years ago

Not seeing any indication that the main plugin needed to be a listener. Looks clean to me. Likely was cruft left from first draft ; given presence of the "growAndPersistBlock" function in main RB class, I'd bet that was the original listener decorated function. When the decoration was moved to PlayerListener, the interface probably just wasn't removed from main RB class.

Good catch, should be safe to merge.

ttk2 commented 9 years ago

hey @plebes are you on the Civcraft form? I would like to add you to the developers group