search

Civcraft / RealisticBiomes

Do not open issues here; open them on the maintained fork @ DevotedMC
https://github.com/DevotedMC/RealisticBiomes
7 stars 14 forks source link

Fix: Reloading of config only done if default created. #18

Closed plebes closed 9 years ago

plebes commented 9 years ago

Problem: The configuration file was being "reloaded" from file regardless of the creation or non-creation of a default configuration. (Loaded twice when the file was fine.)

Fix: The reloading is done only if a default configuration had to be created into the data directory due to a missing or corrupted configuration (command was moved inside the conditional block).

ttk2 commented 9 years ago

looks like a good fix, I will let one of the dev guys merge it, thanks for getting simple things like this! Hopefully it saves us some trouble down the road.

On Fri, May 29, 2015 at 10:37 PM plebes notifications@github.com wrote:

Problem: The configuration file was being "reloaded" from file regardless of the creation or non-creation of a default configuration. (Loaded twice when the file was fine.)

Fix: The reloading is done only if a default configuration had to be created into the data directory due to a missing or corrupted configuration

(command was moved inside the conditional block).

You can view, comment on, or merge this pull request online at:

https://github.com/Civcraft/RealisticBiomes/pull/18 Commit Summary

  • Fix: Reloading of config only done if default created.

File Changes

Patch Links:

— Reply to this email directly or view it on GitHub https://github.com/Civcraft/RealisticBiomes/pull/18.

ttk2 commented 9 years ago

merged testing tomorrow.